[debbugs-tracker] bug#19044: closed ('guix-register -p' should perform deduplication)

[GNU bug Tracking System]

Your message dated Wed, 10 Jun 2015 14:13:45 +0200
with message-id <address@hidden>
and subject line Re: bug#19044: 'guix-register -p' should perform deduplication
has caused the debbugs.gnu.org bug report #19044,
regarding 'guix-register -p' should perform deduplication
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
19044: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19044
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 'guix-register -p' should perform deduplication
>
>
>
>
> Date: 
>
> Thu, 13 Nov 2014 17:56:35 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
>
>
>
>
> When used with -p (as is the case when building a disk/VM image),
> ‘guix-register’ doesn’t do any deduplication in the target store, as
> noted in the source:
>
>   /* XXX: When PREFIX is non-empty, store->linksDir points to the original
>      store's '.links' directory, which means 'optimisePath' would try to link
>      to that instead of linking to the target store.  Thus, disable
>      deduplication in this case.  */
>   if (optimize && prefix.empty ())
>     {
>       /* Make sure deduplication is enabled.  */
>       settings.autoOptimiseStore = true;
>
>       foreach (ValidPathInfos::const_iterator, i, infos)
>         store->optimisePath (i->path);
>     }
>
> This should be fixed, but may need to diverge slightly from upstream
> libstore.
>
> Ludo’.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#19044: 'guix-register -p' should perform deduplication
>
>
>
>
> Date: 
>
> Wed, 10 Jun 2015 14:13:45 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
>
>
>
>
> address@hidden (Ludovic Courtès) skribis:
>
> > When used with -p (as is the case when building a disk/VM image),
> > ‘guix-register’ doesn’t do any deduplication in the target store
>
> Fixed in 3697558.
>
> Ludo’.
>
>
> --- End Message ---