[debbugs-tracker] bug#19536: closed ([PATCH] package-upload-buffer-internal fails for tar files)

[GNU bug Tracking System]

Your message dated Wed, 18 Feb 2015 01:03:38 +0000
with message-id <address@hidden>
and subject line Re: package-upload-buffer-internal fails for tar files
has caused the debbugs.gnu.org bug report #19536,
regarding [PATCH] package-upload-buffer-internal fails for tar files
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
19536: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19536
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] package-upload-buffer-internal fails for tar files
>
>
>
>
> Date: 
>
> Thu, 08 Jan 2015 03:33:06 +0000
>
>
>
>
> It creates a file with a ⌜.tar⌝ extension that isn't a valid tar file.
>
> Since elpa.gnu.org _does_ have valid tar files, I guess somebody wrote a script 
> to work around this bug by overwriting the invalid tar files with the originals.
>
> I'm submitting a patch for this since it affects validation of my patch for bug 
> #19479, and I'm submitting the latter patch because it fixes a security 
> vulnerability.
>
> --- emacs-24.4/lisp/emacs-lisp/package-x.el
> +++ emacs-24.4/lisp/emacs-lisp/package-x.el
> @@ -243,7 +243,7 @@
>                              (concat (symbol-name pkg-name) "-readme.txt")
>                              package-archive-upload-base)))
>  
> -           (set-buffer pkg-buffer)
> +           (set-buffer (if (eq file-type 'tar) tar-data-buffer pkg-buffer))
>             (write-region (point-min) (point-max)
>                           (expand-file-name
>                            (format "%s-%s.%s" pkg-name pkg-version extension)
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: package-upload-buffer-internal fails for tar files
>
>
>
>
> Date: 
>
> Wed, 18 Feb 2015 01:03:38 +0000
>
>
>
>
> Fixed in trunk.
>
>
> --- End Message ---