[debbugs-tracker] bug#18006: closed (Simplify via set_binary_mode)

[GNU bug Tracking System]

Your message dated Tue, 15 Jul 2014 12:39:36 -0700
with message-id <address@hidden>
and subject line Re: bug#18006: Simplify via set_binary_mode
has caused the debbugs.gnu.org bug report #18006,
regarding Simplify via set_binary_mode
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
18006: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18006
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Simplify via set_binary_mode Date: Sat, 12 Jul 2014 13:52:28 -0700 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

Tags: patch

Attached is a proposed minor simplification to have Emacs use set_binary_mode more consistently. I'm filing this as a bug report to give Eli a heads-up, as it affects the Microsoft ports. This is relative to trunk bzr 117525.

binary-io.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#18006: Simplify via set_binary_mode
>
>
>
>
> Date: 
>
> Tue, 15 Jul 2014 12:39:36 -0700
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
>
>
>
>
> Eli Zaretskii wrote:
> > The lib-src part looks OK to me.
>
> Thanks, I installed that.
>
> > This part doesn't look right.  If we don't use "rt", then when
> > emacs_fopen calls emacs_open
>
> Ah, sorry, that part was a false alarm.  I forgot that emacs_fopen 
> doesn't pass the mode string to fopen, which means there's no 
> portability bug there after all.  If we were going to make a change I'd 
> prefer your (a) to your (b) as it keeps the mainline code simpler, but 
> doing nothing at all is simpler yet, so I'll close the bug.
>
>
> --- End Message ---