|
From: | GNU bug Tracking System |
Subject: | [debbugs-tracker] bug#16729: closed (suggested small refactoring in dfa.c) |
Date: | Sat, 01 Mar 2014 06:57:03 +0000 |
Your message dated Fri, 28 Feb 2014 22:56:49 -0800 with message-id <address@hidden> and subject line Re: suggested small refactoring in dfa.c has caused the debbugs.gnu.org bug report #16729, regarding suggested small refactoring in dfa.c to be marked as done. (If you believe you have received this mail in error, please contact address@hidden) -- 16729: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16729 GNU Bug Tracking System Contact address@hidden with problems
--- Begin Message ---Subject: suggested small refactoring in dfa.c Date: Wed, 12 Feb 2014 06:58:53 -0700 User-agent: Heirloom mailx 12.4 7/29/08 Hi Jim, Paul. Here is the small refactoring I suggest for dfa.c Thanks, Arnold -------------------- diff --git a/dfa.c b/dfa.c index d5e7fdf..dcd28e5 100644 --- a/dfa.c +++ b/dfa.c @@ -1767,18 +1767,19 @@ add_utf8_anychar (void) static void atom (void) { - if (0) + if (MBS_SUPPORT && tok == WCHAR) { - /* empty */ - } - else if (MBS_SUPPORT && tok == WCHAR) - { - addtok_wc (case_fold ? towlower (wctok) : wctok); - if (case_fold && iswalpha (wctok)) - { - addtok_wc (towupper (wctok)); - addtok (OR); - } + if (! case_fold) + addtok_wc (wctok); + else + { + addtok_wc (towlower (wctok)); + if (iswalpha (wctok)) + { + addtok_wc (towupper (wctok)); + addtok (OR); + } + } tok = lex (); }
--- End Message ---
--- Begin Message ---Subject: Re: suggested small refactoring in dfa.c Date: Fri, 28 Feb 2014 22:56:49 -0800 My recent changes to dfa.c have incorporated the removal of that "if (0)" and have refactored the rest so I'm marking this bug as done. User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0
--- End Message ---
[Prev in Thread] | Current Thread | [Next in Thread] |