--- Begin Message ---
Subject: |
[5ef95e85] fails to build with --enable-gcc-warnings in some configurations |
Date: |
Fri, 29 Nov 2013 17:02:24 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
As of 5ef95e85, building with GCC 4.8.2, --enable-gcc-warnings,
--without-x-toolkit, and GnuTLS 2, fails with:
../../src/xfaces.c:914:0: error: macro "NEAR_SAME_COLOR_THRESHOLD" is not used
[-Werror=unused-macros]
#define NEAR_SAME_COLOR_THRESHOLD 30000
^
cc1: all warnings being treated as errors
../../src/gnutls.c:266:1: error: 'gnutls_audit_log_function' defined but not
used [-Werror=unused-function]
gnutls_audit_log_function (gnutls_session_t session, const char* string)
^
cc1: all warnings being treated as errors
The causes are:
• the NEAR_SAME_COLOR_THRESHOLD macro’s definition is not
properly guarded with #ifdef HAVE_WINDOW_SYSTEM;
• both the declaration and the definition of
gnutls_audit_log_function () are not properly guarded with
#ifdef HAVE_GNUTLS3.
Adding the respective guards fixes both of the GCC errors.
The issue seem not to be fixed in e7203144, either.
--
FSF associate member #7257
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#16001: [5ef95e85] fails to build with --enable-gcc-warnings in some configurations |
Date: |
Sat, 30 Nov 2013 14:32:30 +0100 |
Hello.
There are lot of new errors in window.c, xterm.c and xdisp.c after the
pixelwise resize checkin, so this report is kind of obsolete. But I checked in
fixes for the issues below.
Jan D.
29 nov 2013 kl. 18:02 skrev Ivan Shmakov <address@hidden>:
> As of 5ef95e85, building with GCC 4.8.2, --enable-gcc-warnings,
> --without-x-toolkit, and GnuTLS 2, fails with:
>
> ../../src/xfaces.c:914:0: error: macro "NEAR_SAME_COLOR_THRESHOLD" is not
> used [-Werror=unused-macros]
> #define NEAR_SAME_COLOR_THRESHOLD 30000
> ^
> cc1: all warnings being treated as errors
>
> ../../src/gnutls.c:266:1: error: 'gnutls_audit_log_function' defined but not
> used [-Werror=unused-function]
> gnutls_audit_log_function (gnutls_session_t session, const char* string)
> ^
> cc1: all warnings being treated as errors
>
> The causes are:
>
> • the NEAR_SAME_COLOR_THRESHOLD macro’s definition is not
> properly guarded with #ifdef HAVE_WINDOW_SYSTEM;
>
> • both the declaration and the definition of
> gnutls_audit_log_function () are not properly guarded with
> #ifdef HAVE_GNUTLS3.
>
> Adding the respective guards fixes both of the GCC errors.
>
> The issue seem not to be fixed in e7203144, either.
>
> --
> FSF associate member #7257
>
>
--- End Message ---