[debbugs-tracker] bug#15965: closed (24.3.50; [PATCH] eww: ask confirmation before quitting)

[GNU bug Tracking System]

Your message dated Tue, 26 Nov 2013 15:10:31 -0500
with message-id <address@hidden>
and subject line Re: bug#15966: bug#15967: 24.3.50; [PATCH] eww: use 
eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; 
[PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] 
eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current 
URL is not entered automatically, after ewwstarts.s.
has caused the debbugs.gnu.org bug report #15965,
regarding 24.3.50; [PATCH] eww: ask confirmation before quitting
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
15965: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15965
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.3.50; [PATCH] eww: ask confirmation before quitting
>
>
>
>
> Date: 
>
> Sun, 24 Nov 2013 23:12:47 +0900
>
>
>
>
> User-agent: 
>
> mu4e 0.9.9.6pre2; emacs 24.3.50.2
>
>
>
>
> eww should ask "yes or no" before quitting, since only "q" key to quit is
> easy to mistake.
>
> Signed-off-by: Kenjiro NAKAYAMA <address@hidden>
>
>         * net/eww.el (eww-quit): ask confirmation before quitting eww
>
> ---
>  lisp/net/eww.el | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> index 86e0977..265f6c8 100644
> --- a/lisp/net/eww.el
> +++ b/lisp/net/eww.el
> @@ -403,8 +403,10 @@ word(s) will be searched for via `eww-search-prefix'."
>  (defun eww-quit ()
>    "Exit the Emacs Web Wowser."
>    (interactive)
> -  (setq eww-history nil)
> -  (kill-buffer (current-buffer)))
> +  (if (y-or-n-p "quit eww? ")
> +      (progn
> +       (setq eww-history nil)
> +       (kill-buffer (current-buffer)))))
>
>  (defun eww-back-url ()
>    "Go to the previously displayed page."
> -- 
> 1.8.3.1
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#15966: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s.
>
>
>
>
> Date: 
>
> Tue, 26 Nov 2013 15:10:31 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux)
>
>
>
>
> On Tue, 26 Nov 2013 20:51:49 +0900 Kenjiro NAKAYAMA <address@hidden> wrote: 
>
> KN> I consolidated the patches, please include the patch if appreciated.
>
> OK; done.  I changed "add bookmark this page?" to "bookmark this page?"
> but otherwise had no issues.
>
> Thanks!
> Ted
>
>
> --- End Message ---