[debbugs-tracker] bug#13886: closed (24.3; vc-annotate won't show the log entry with git backend and hidden annotatation)

[GNU bug Tracking System]

Your message dated Mon, 25 Nov 2013 04:30:25 +0200
with message-id <address@hidden>
and subject line Re: bug#13886: 24.3; vc-annotate won't show the log entry with 
git backend and hidden annotatation
has caused the debbugs.gnu.org bug report #13886,
regarding 24.3; vc-annotate won't show the log entry with git backend and 
hidden annotatation
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
13886: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13886
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation Date: Wed, 6 Mar 2013 02:37:51 +0000

While in vc-annotate mode, with a git backend, if one hides the

annotations with vc-annotate-toggle-annotation-visiblity, and

tries to run vc-annotate-show-log-revision-at-line, it will display the

message "Cannot extract revision number from the current line".

Fixable by changing (move-beginning-of-line 1) to (forward-line 0) here:

(defun vc-git-annotate-extract-revision-at-line ()

  (save-excursion

    (forward-line 0)

    (when (looking-at "\\([0-9a-f^][0-9a-f]+\\) \\(\\([^(]+\\) \\)?")

      (let ((revision (match-string-no-properties 1)))

(if (match-beginning 2)

   (let ((fname (match-string-no-properties 3)))

     ;; Remove trailing whitespace from the file name.

     (when (string-match " +\\'" fname)

(setq fname (substring fname 0 (match-beginning 0))))

     (cons revision

   (expand-file-name fname (vc-git-root default-directory))))

 revision)))))

Evgeni

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#13886: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation
>
>
>
>
> Date: 
>
> Mon, 25 Nov 2013 04:30:25 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
>
>
>
>
> Version: 24.4
>
> Thanks for the report, fixed in 115219.
>
> Though I've changed it to use `beginning-of-line' for better
> consistency, because implementations of this command in other backends
> do that.
>
>
> --- End Message ---