[debbugs-tracker] bug#15739: closed (Doesn't support clang as well as it could.)

[GNU bug Tracking System]

Your message dated Fri, 01 Nov 2013 18:00:23 -0400
with message-id <address@hidden>
and subject line Re: bug#15739: Doesn't support clang as well as it could.
has caused the debbugs.gnu.org bug report #15739,
regarding Doesn't support clang as well as it could.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
15739: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15739
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Doesn't support clang as well as it could. Date: Sun, 27 Oct 2013 14:53:20 -0500

There are plenty of macros that only check for GNU GCC and don't bother checking support from other popular compilers. For example, in libguile/__scm.h, the macros SCM_NORETURN, SCM_UNUSED, SCM_EXPECT, and many more, all only check for GCC support. Most (if not all) of these language extensions are supported by Clang, and usually using the same exact syntax!

I'll submit a patch that adds Clang support to these macros. See <http://clang.llvm.org/docs/LanguageExtensions.html> for the documentation about this.

--
Matt Sicker <address@hidden>

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#15739: Doesn't support clang as well as it could.
>
>
>
>
> Date: 
>
> Fri, 01 Nov 2013 18:00:23 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
>
>
>
>
> Hi Matt,
>
> Matt Sicker <address@hidden> writes:
> > I noticed that clang reports to be GCC version 4.2, so most of what I
> > thought might be wrong wasn't. Therefore, the patch was far easier and
> > smaller than I expected. This isn't too high a priority, but it does
> > add support for clang where the code would normally check for GCC
> > 4.3+. Clang even supports C++ static_assert supposedly, so there's a
> > check for that as well.
> >
> > -- 
> > Matt Sicker <address@hidden> 
> >
> >
> > From 2b02509f53a247784b4bb0be96061e46b53b0c4e Mon Sep 17 00:00:00 2001
> > From: Matt Sicker <address@hidden>
> > Date: Sun, 27 Oct 2013 16:54:06 -0500
> > Subject: [PATCH] Updated a couple compiler checks to support clang.
> >
> > * lib/poll.c [__clang__]: Same functionality as GCC 4.3+ for ignoring
> >   the (nfd < 0) tests.
> > * lib/verify.h [__has_feature(c_static_assert)]: Enables
> >   _GL_HAVE__STATIC_ASSERT when clang feature is available for C.
> > * lib/verify.h [__has_feature(cxx_static_assert)]: Enables
> > * _GL_HAVE_STATIC_ASSERT when clang feature is available for C++.
>
> Both of these files are part of gnulib.  As a matter of policy, we do
> not change those files in our repository.  Instead we update from
> gnulib's repository from time to time.
>
> Can you please send this problem report and patch to
> <address@hidden> ?
>
> I'm closing this bug, since there's nothing for us to do in Guile.  If
> you find any clang-related problems in Guile itself, please let us know.
>
>      Thanks,
>        Mark
>
>
> --- End Message ---