[debbugs-tracker] bug#14043: closed (24.3.50; Compiler warning in cygw32 build on x86_64-cygwin)

[GNU bug Tracking System]

Your message dated Sat, 23 Mar 2013 20:17:45 -0400
with message-id <address@hidden>
and subject line Re: bug#14043: 24.3.50; Compiler warning in cygw32 build on 
x86_64-cygwin
has caused the debbugs.gnu.org bug report #14043,
regarding 24.3.50; Compiler warning in cygw32 build on x86_64-cygwin
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
14043: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14043
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 24.3.50; Compiler warning in cygw32 build on x86_64-cygwin Date: Sat, 23 Mar 2013 12:40:38 -0400 User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2

In w32term.c:w32_initialize, the line

  DWORD input_locale_id = (DWORD) GetKeyboardLayout (0);

(line 6666 in the current trunk) generates a "cast from pointer to integer of different size" warning in the cygw32 build on 64-bit Cygwin. I think that the warning can be safely ignored in this case, but I would prefer to avoid it.

The attached patch fixes this. I'm wondering, however, whether the same warning occurs on 64-bit Windows. If so, maybe that should be fixed at the same time, but I don't know enough about Windows programming to do this.

Ken

In GNU Emacs 24.3.50.2 (x86_64-pc-cygwin)
 of 2013-03-20 on fiona
Bzr revision: 112086 address@hidden
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --without-makeinfo --with-w32 CFLAGS=-g3 -O0'

w32term.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#14043: 24.3.50;	Compiler warning in cygw32 build on x86_64-cygwin
>
>
>
>
> Date: 
>
> Sat, 23 Mar 2013 20:17:45 -0400
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (Windows NT 6.1; WOW64;	rv:17.0) Gecko/20130107 Thunderbird/17.0.2
>
>
>
>
> On 3/23/2013 6:33 PM, Ken Brown wrote:
> > On 3/23/2013 2:25 PM, Eli Zaretskii wrote:
> > > Does the alternative patch below also work?  I'd like to avoid
> > > ifdef's, if possible.
> >
> > Yes, it does.  I too am glad to see a solution that avoids the ifdefs.
>
> I've committed the change as bzr revision 112120 and am closing the bug 
> report.
>
> Ken
>
>
> --- End Message ---