[debbugs-tracker] bug#13525: closed (8.20 - [seq 1 3 1] treated as [seq 1 3])

[GNU bug Tracking System]

Your message dated Tue, 22 Jan 2013 11:23:22 +0000
with message-id <address@hidden>
and subject line Re: bug#13525: 8.20 - [seq 1 3 1] treated as [seq 1 3]
has caused the debbugs.gnu.org bug report #13525,
regarding 8.20 - [seq 1 3 1] treated as [seq 1 3]
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
13525: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13525
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 8.20 - [seq 1 3 1] treated as [seq 1 3]
>
>
>
>
> Date: 
>
> Tue, 22 Jan 2013 11:43:14 +0100 (CET)
>
>
>
>
> Dear all,
>
> There is another bug that sneaked into the speed patch of seq on 13.09.12:
>
> 560   if (all_digits_p (argv[optind])
> 561       && (n_args == 1 || all_digits_p (argv[optind + 1]))
> 562       && (n_args < 3 || STREQ ("1", argv[optind + 2]))
> 563       && !equal_width && !format_str && strlen (separator) == 1)
>
> That should probably be:
> 560   if (all_digits_p (argv[optind])
> 561       && (n_args == 1 || all_digits_p (argv[optind + 1]))
> 562       && (n_args < 3 || STREQ ("1", argv[optind + 1]))
> 563       && !equal_width && !format_str && strlen (separator) == 1)
>
> Best regards,
>  Marcel
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#13525: 8.20 - [seq 1 3 1] treated as [seq 1 3] Date: Tue, 22 Jan 2013 11:23:22 +0000 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

On 01/22/2013 10:43 AM, Marcel Böhme wrote:

Dear all,

There is another bug that sneaked into the speed patch of seq on 13.09.12:

560   if (all_digits_p (argv[optind])
561       && (n_args == 1 || all_digits_p (argv[optind + 1]))
562       && (n_args < 3 || STREQ ("1", argv[optind + 2]))
563       && !equal_width && !format_str && strlen (separator) == 1)

That should probably be:
560   if (all_digits_p (argv[optind])
561       && (n_args == 1 || all_digits_p (argv[optind + 1]))
562       && (n_args < 3 || STREQ ("1", argv[optind + 1]))
563       && !equal_width && !format_str && strlen (separator) == 1)

Sigh we really messed up seq in that release :(
The attached should fix it:

I also notice another regression,
which I'll fix in a moment.

 $ seq 0 1 0
 0
 1

thanks,
Pádraig.

seq-ignored-step.diff
Description: Text Data

--- End Message ---