[debbugs-tracker] bug#12244: closed ([patch] URI encoding bugs)

[GNU bug Tracking System]

Your message dated Sun, 26 Aug 2012 23:37:36 +0200
with message-id <address@hidden>
and subject line Re: bug#12244: [patch] URI encoding bugs
has caused the debbugs.gnu.org bug report #12244,
regarding [patch] URI encoding bugs
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
12244: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12244
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [patch] URI encoding bugs Date: Mon, 20 Aug 2012 23:19:12 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)

Hi,

There are two bugs in the current uri-encode procedure in (web
uri).

Firstly, if you have an octet less than 16 it only gets encoded to %
HEXDIGIT instead of % HEXDIGIT HEXDIGIT.

scheme@(guile−user)> (uri-encode "foo\nbar")
$30 = "foo%abar"

Secondly, if you have a string with no unreserved characters, nothing
gets encoded.
scheme@(guile−user)> (uri-encode "<>\\^")
$31 = "<>\\∧"
scheme@(guile−user)> (uri-encode "<>\\^a")
$32 = "%3c%3e%5c%5ea"

Patches attached. Cheers,

-- 
Ian Price -- shift-reset.com

"Programming is like pinball. The reward for doing it well is
the opportunity to do it again" - from "The Wizardy Compiled"

0001-Fix-uri-encoding-for-octets-0-15.patch
Description: octets 0-15 patch

0002-Fix-uri-encoding-for-strings-with-no-unreserved-char.patch
Description: no unreserved chars patch

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#12244: [patch] URI encoding bugs
>
>
>
>
> Date: 
>
> Sun, 26 Aug 2012 23:37:36 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.1 (gnu/linux)
>
>
>
>
> Hi Ian,
>
> Applied both, thanks!
>
> Ludo’.
>
>
> --- End Message ---