emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-bug-tracker] bug#8258: closed (INFOPATH bug on Windows)


From: GNU bug Tracking System
Subject: [Emacs-bug-tracker] bug#8258: closed (INFOPATH bug on Windows)
Date: Wed, 16 Mar 2011 00:05:01 +0000

Your message dated Wed, 16 Mar 2011 01:04:05 +0100
with message-id <address@hidden>
and subject line Re: bug#8258: INFOPATH bug on Windows
has caused the GNU bug report #8258,
regarding INFOPATH bug on Windows
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
8258: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8258
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: INFOPATH bug on Windows Date: Tue, 15 Mar 2011 20:44:40 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
Hi,

on Windows, Emacs 23.3 fails to parse INFOPATH due to a hard-coded
colon as path separator.  Below is a patch together with a change
log entry.


2011-03-11  Ralph Schleicher  <address@hidden>

        * info.el (info-initialize): Replace all uses of `:' with
        path-separator for compatibility with non-Unix systems.
        Cache quoting of path-separator.


--- emacs-23.3/lisp/info.el.orig        2011-01-08 12:45:14 +0100
+++ emacs-23.3/lisp/info.el     2011-03-11 11:45:14 +0100
@@ -588,15 +588,15 @@
 (defun info-initialize ()
   "Initialize `Info-directory-list', if that hasn't been done yet."
   (unless Info-directory-list
-    (let ((path (getenv "INFOPATH")))
+    (let ((path (getenv "INFOPATH"))
+         (sep (regexp-quote path-separator)))
       (setq Info-directory-list
            (prune-directory-list
             (if path
-                (if (string-match ":\\'" path)
-                    (append (split-string (substring path 0 -1)
-                                          (regexp-quote path-separator))
+                (if (string-match (concat sep "\\'") path)
+                    (append (split-string (substring path 0 -1) sep)
                             (Info-default-dirs))
-                  (split-string path (regexp-quote path-separator)))
+                  (split-string path sep))
               (Info-default-dirs)))))))
 
 ;;;###autoload


-- 
Ralph



--- End Message ---
--- Begin Message --- Subject: Re: bug#8258: INFOPATH bug on Windows Date: Wed, 16 Mar 2011 01:04:05 +0100
> on Windows, Emacs 23.3 fails to parse INFOPATH due to a hard-coded
> colon as path separator.

In fact, the current code parses INFOPATH (quite by accident), but
fails to take into account the case where INFOPATH should be appended
to Info-default-directory-list.

So, yours is a valid fix and I've committed it to the emacs-23 branch.

Thanks,

    Juanma


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]