emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-bug-tracker] bug#6632: closed (23.2.50; dired-mode should use [re


From: GNU bug Tracking System
Subject: [Emacs-bug-tracker] bug#6632: closed (23.2.50; dired-mode should use [remap ...] instead of hard-coded overriding of global key bindings)
Date: Thu, 22 Jul 2010 11:57:01 +0000

Your message dated Thu, 22 Jul 2010 13:57:00 +0200
with message-id <address@hidden>
and subject line Re: bug#6632: 23.2.50; dired-mode should use [remap ...] 
instead of  hard-coded overriding of global key bindings
has caused the GNU bug report #6632,
regarding 23.2.50; dired-mode should use [remap ...] instead of hard-coded 
overriding of global key bindings
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
6632: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6632
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 23.2.50; dired-mode should use [remap ...] instead of hard-coded overriding of global key bindings Date: Wed, 14 Jul 2010 18:58:13 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2.50 (gnu/linux)
dired-mode uses hard-coding when it rebinds some global key bindings.
For example, there is the following line in dired.el file:

    (define-key map "\C-n" 'dired-next-line)

Therefore it overrides the global C-n key, whatever its command is in
user's keymap. The command should be bound like this:

    (define-key map [remap next-line] 'dired-next-line)

Using [remap ...] is preferred because it makes it possible for user to
redefine the global keymap they way she wishes and keys will still
automatically get their mode-specific behaviour. The attached patch
fixes this for dired-mode.

Attachment: dired-mode-remap.diff
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#6632: 23.2.50; dired-mode should use [remap ...] instead of hard-coded overriding of global key bindings Date: Thu, 22 Jul 2010 13:57:00 +0200
On Wed, Jul 14, 2010 at 17:58, Teemu Likonen <address@hidden> wrote:

> The attached patch fixes this for dired-mode.

Committed, thanks.

    Juanma


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]