Re: [Duplicity-talk] New megatools backend in 0.7.14

[edgar . soldin]

Ken,

sorry to rain on your parade. but joining the list is not proper. the entries 
may contain spaces. you could start trying to quote wrap but it'd be much 
easier and cleaner to simply to deliver the list down to the Popen call, which 
actually uses a list as well. now you join the list just to have it split into 
a list again later on for subprocess.Popen().

..ede/duply.net

On 9/6/2017 16:40, Kenneth Loafman wrote:
> Done.
> 
> ...Ken
> 
> 
> On Wed, Sep 6, 2017 at 8:48 AM, Kenneth Loafman <address@hidden> wrote:
> 
>> No problem, will do.
>>
>> ...Ken
>>
>>
>> On Wed, Sep 6, 2017 at 7:32 AM, <address@hidden> wrote:
>>
>>> ok,
>>>
>>> the man page needs to be updated accordingly. can you take care of this
>>> as well? i just posted a request on the megabackend bug ticket and reopened
>>> it.
>>>
>>> ..ede/duply.net
>>>
>>> On 06.09.2017 13:57, Kenneth Loafman wrote:
>>>> I'll take care of it.  My bad.
>>>>
>>>> ...Ken
>>>>
>>>>
>>>> On Wed, Sep 6, 2017 at 5:58 AM, <address@hidden> wrote:
>>>>
>>>>> On 06.09.2017 12:23, Richard McGraw via Duplicity-talk wrote:
>>>>>> Hello,
>>>>>>
>>>>>> The new megabackend.py calls self.subprocess_popen(cmd) where cmd is a
>>>>>> list of arguments (in upload function and others). But
>>>>>> Backend.subprocess_popen() expects a string.
>>>>>>
>>>>>> The file linked in this
>>>>>> post: https://bugs.launchpad.net/duplicity/+bug/1394386/comments/7
>>> calls
>>>>>> subprocess.call(cmd)
>>>>>>
>>>>>
>>>>> for ease of use, we should probably just extend
>>>>> backend.__subprocess_popen() to detect if commandline/args is a list
>>> and
>>>>> use it directly, skipping the arg list generation.
>>>>>
>>>>> Ken: want me to give it a try?
>>>>> Richard: do you want to?
>>>>>
>>>>> ..ede/duply.net
>>>>>
>>>>
>>>
>>>
>>
>