[Duplicity-talk] URL decode username and password

[Dan Muresan]

Hi all,

I've tried to use duplicity on a DAV host and ran intro problems. After
struggling with it, I've traced these problems to the fact that
parsed_url.username is never URL decoded in backends.py.

My username is an e-mail address, so I supply a URL like

webdav://USER%40HOST.COM:address@hidden/dav

Duplicity needs to accept url-encoded usernames and passwords, otherwise
it's impossible to include special chars in these. In fact I'm surprised
that this was not taken into account, given that there is no other
avenue to supply a username...

The fix is simple: for usernames, replace parsed_url.username with

urllib.unquote (parsed_url.username)

in backends.py. This probably helps the FTP backend too.

For the password, similarly change the get_password method to use
urllib.unquote (self.parsed_url.password) in backends.py.


Thanks,
Dan