[Pnet-developers] [bugs #10772] TextBox.Lines incorrectly handles empty lines

[Gopal.V]

This mail is an automated notification from the bugs tracker
 of the project: DotGNU Portable.NET.

/**************************************************************************/
[bugs #10772] Latest Modifications:

Changes by: 
                Gopal.V <address@hidden>
'Date: 
                Mon 10/25/2004 at 13:17 (Asia/Calcutta)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
Fixed in CVS 25th Oct 2004. Please note that a couple more
problems with Lines[] has been fixed.






/**************************************************************************/
[bugs #10772] Full Item Snapshot:

URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=10772>
Project: DotGNU Portable.NET
Submitted by: 0
On: Fri 10/22/2004 at 23:50

Category:  None
Severity:  5 - Average
Item Group:  None
Resolution:  Fixed
Privacy:  Public
Assigned to:  None
Status:  Closed


Summary:  TextBox.Lines incorrectly handles empty lines

Original Submission:  Currently, TextBox.Lines will incorrectly merge lines 
across empty lines in the text, and the "extra" array elements are nullrefs.  

i is incremented too far when a line is detected.
This tries to be clearer by putting all the incrementing in one location

--- TextBox.cs~:2004-10-14 14:49:40.000000000 -0700tem.Windows.Forms >vim Te
+++ TextBox.cs  2004-10-22 16:44:39.000000000 -0700
@@ -423,7 +423,7 @@roject/csharp/dotgnu/pnetlib/System.Windows.Forms >vim 
TextBo                            .cs                    int start = 0;
                        line = 0;
                        // Break into strings
-                       for (int i = 0; i < Text.Length; i++)
+                       for (int i = 0; i < Text.Length;)
                        {
                                if (Text[i] == 'r' && i < Text.Length - 1 && 
Text[i+1] == 'n') // Look for CRLF
                                {
@@ -431,6 +431,7 @@
                                        i+=2;
                                        start = i;
                                }
+                                else i++;
                        }
                        
                        return lines;

Follow-up Comments
------------------


-------------------------------------------------------
Date: Mon 10/25/2004 at 13:17       By: Gopal.V <t3rmin4t0r>
Fixed in CVS 25th Oct 2004. Please note that a couple more
problems with Lines[] has been fixed.

-------------------------------------------------------
Date: Fri 10/22/2004 at 23:54       By: 0 <None>
Frowny face, it ate my formatting.
I will try attaching.






File Attachments
-------------------

-------------------------------------------------------
Date: Fri 10/22/2004 at 23:54  Name: textbox-lines.diff  Size: 490B   By: None

http://savannah.gnu.org/bugs/download.php?item_id=10772&amp;item_file_id=1795






For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=10772>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/