[dotgnu-pnet-commits] pnetlib ./ChangeLog DotGNU.XmlRpc/Serialization...

[Deryk Robosson]

CVSROOT:        /sources/dotgnu-pnet
Module name:    pnetlib
Branch:         
Changes by:     Deryk Robosson <address@hidden> 06/05/14 11:22:47

Modified files:
        .              : ChangeLog 
        DotGNU.XmlRpc/Serialization: MethodCallFormatter.cs 
                                     MethodResponseFormatter.cs 
        DotGNU.XmlRpc  : XmlRpcClientProtocol.cs XmlRpcWriter.cs 

Log message:
        validate arguments of public methods

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/dotgnu-pnet/pnetlib/ChangeLog.diff?tr1=1.2403&tr2=1.2404&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/dotgnu-pnet/pnetlib/DotGNU.XmlRpc/Serialization/MethodCallFormatter.cs.diff?tr1=1.2&tr2=1.3&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/dotgnu-pnet/pnetlib/DotGNU.XmlRpc/Serialization/MethodResponseFormatter.cs.diff?tr1=1.2&tr2=1.3&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/dotgnu-pnet/pnetlib/DotGNU.XmlRpc/XmlRpcClientProtocol.cs.diff?tr1=1.2&tr2=1.3&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/dotgnu-pnet/pnetlib/DotGNU.XmlRpc/XmlRpcWriter.cs.diff?tr1=1.2&tr2=1.3&r1=text&r2=text

Patches:
Index: pnetlib/ChangeLog
diff -u pnetlib/ChangeLog:1.2403 pnetlib/ChangeLog:1.2404
--- pnetlib/ChangeLog:1.2403    Sun May 14 11:00:46 2006
+++ pnetlib/ChangeLog   Sun May 14 11:22:46 2006
@@ -7,6 +7,10 @@
        loops.
        * DotGNU.XmlRpc/XmlRpcException.cs: Implement standard exception
        constructors.  Add [Serializable] attribute.
+       * DotGNU.XmlRpc/Serialization/MethodCallFormatter.cs,
+       DotGNU.XmlRpc/Serialization/MethodResponseFormatter.cs,
+       DotGNU.XmlRpc/XmlRpcClientProtocol.cs, DotGNU.XmlRpc/XmlRpcWriter.cs:
+       validate arguments of public methods
 
 2006-05-13  Deryk Robosson  <address@hidden>
 
Index: pnetlib/DotGNU.XmlRpc/Serialization/MethodCallFormatter.cs
diff -u pnetlib/DotGNU.XmlRpc/Serialization/MethodCallFormatter.cs:1.2 
pnetlib/DotGNU.XmlRpc/Serialization/MethodCallFormatter.cs:1.3
--- pnetlib/DotGNU.XmlRpc/Serialization/MethodCallFormatter.cs:1.2      Wed Oct 
 6 16:44:50 2004
+++ pnetlib/DotGNU.XmlRpc/Serialization/MethodCallFormatter.cs  Sun May 14 
11:22:47 2006
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  *
- * $Revision: 1.2 $  $Date: 2004/10/06 16:44:50 $
+ * $Revision: 1.3 $  $Date: 2006/05/14 11:22:47 $
  * 
  * --------------------------------------------------------------------------
  */
@@ -53,6 +53,16 @@
     // Writes a XmlRpc MethodCall from the XmlRpcMethod object
     public void Serialize( Stream stream, object o )
     {
+      if(stream == null)
+      {
+        throw new ArgumentNullException("stream", "Argument must not be null");
+      }
+
+      if(o == null)
+      {
+        throw new ArgumentNullException("o", "Argument must not be null");
+      }
+
       if( o is XmlRpcMethod ) {
        //StringWriter s = new StringWriter();
        //XmlRpcWriter w = new XmlRpcWriter( s );
Index: pnetlib/DotGNU.XmlRpc/Serialization/MethodResponseFormatter.cs
diff -u pnetlib/DotGNU.XmlRpc/Serialization/MethodResponseFormatter.cs:1.2 
pnetlib/DotGNU.XmlRpc/Serialization/MethodResponseFormatter.cs:1.3
--- pnetlib/DotGNU.XmlRpc/Serialization/MethodResponseFormatter.cs:1.2  Wed Oct 
 6 16:44:50 2004
+++ pnetlib/DotGNU.XmlRpc/Serialization/MethodResponseFormatter.cs      Sun May 
14 11:22:47 2006
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  *
- * $Revision: 1.2 $  $Date: 2004/10/06 16:44:50 $
+ * $Revision: 1.3 $  $Date: 2006/05/14 11:22:47 $
  * 
  * --------------------------------------------------------------------------
  */
@@ -54,6 +54,16 @@
     // Writes an object as an XmlRpc response
     public void Serialize( Stream stream, object o )
     {
+      if(stream == null)
+      {
+        throw new ArgumentNullException("stream", "Argument must not be null");
+      }
+
+      if(o == null)
+      {
+        throw new ArgumentNullException("o", "Argument must not be null");
+      }
+
       if( o is XmlRpcResponse ){
        StreamWriter sw = new StreamWriter( stream );
        XmlRpcWriter w = new XmlRpcWriter( sw );
Index: pnetlib/DotGNU.XmlRpc/XmlRpcClientProtocol.cs
diff -u pnetlib/DotGNU.XmlRpc/XmlRpcClientProtocol.cs:1.2 
pnetlib/DotGNU.XmlRpc/XmlRpcClientProtocol.cs:1.3
--- pnetlib/DotGNU.XmlRpc/XmlRpcClientProtocol.cs:1.2   Wed Oct  6 16:44:50 2004
+++ pnetlib/DotGNU.XmlRpc/XmlRpcClientProtocol.cs       Sun May 14 11:22:47 2006
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  *
- * $Revision: 1.2 $  $Date: 2004/10/06 16:44:50 $
+ * $Revision: 1.3 $  $Date: 2006/05/14 11:22:47 $
  * 
  * --------------------------------------------------------------------------
  */
@@ -48,6 +48,16 @@
 
                public Object[] Invoke(String method_name, Object[] args )
                {
+                       if(method_name == null)
+                       {
+                               throw new ArgumentNullException("method_name", 
"Argument must not be null");
+                       }
+
+                       if(args == null)
+                       {
+                               throw new ArgumentNullException("args", 
"Argument must not be null");
+                       }
+
                        MemoryStream ms = new MemoryStream();
                        MethodCallFormatter call = new MethodCallFormatter();
                        XmlRpcMethod method = new XmlRpcMethod( method_name );
Index: pnetlib/DotGNU.XmlRpc/XmlRpcWriter.cs
diff -u pnetlib/DotGNU.XmlRpc/XmlRpcWriter.cs:1.2 
pnetlib/DotGNU.XmlRpc/XmlRpcWriter.cs:1.3
--- pnetlib/DotGNU.XmlRpc/XmlRpcWriter.cs:1.2   Wed Oct  6 16:44:50 2004
+++ pnetlib/DotGNU.XmlRpc/XmlRpcWriter.cs       Sun May 14 11:22:47 2006
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  *
- * $Revision: 1.2 $  $Date: 2004/10/06 16:44:50 $
+ * $Revision: 1.3 $  $Date: 2006/05/14 11:22:47 $
  * 
  * --------------------------------------------------------------------------
  */
@@ -58,6 +58,11 @@
 
     public void Write( XmlRpcMethod method )
     {
+      if(method == null)
+      {
+        throw new ArgumentNullException("method", "Argument cannot be null");
+      }
+
       WriteStartDocument();
       WriteStartElement( "methodCall" );
       WriteElementString( "methodName", method.Name );
@@ -75,6 +80,11 @@
 
     public void Write( XmlRpcResponse response )
     {
+      if(response == null)
+      {
+        throw new ArgumentNullException("response", "Argument cannot be null");
+      }
+
       WriteStartDocument();
       WriteMethodResponse();
       WriteParams();
@@ -86,6 +96,11 @@
     
     public void Write( XmlRpcException e )
     {
+      if(e == null)
+      {
+        throw new ArgumentNullException("e", "Argument cannot be null");
+      }
+
       WriteStartDocument();
       WriteMethodResponse();
       WriteStartElement( "fault" );