[Dolibarr-bugtrack] [Bug #1691] Don't think the ID should be displayed in holiday module

[Doliforge]

Ce message ne s'affiche pas correctement? mettez à jour vos préférences utilisateur.

Dolibarr ERP & CRM » Bugs » bug #1691

Don't think the ID should be displayed in holiday module

Dernières modifications

Raphaël Doursenaud (rdoursenaud)

28/11/2014 17:16 (Europe/Paris)

Thanks!

Changements :

Status:

Open → Closed

Répondre

État

Détails
Submitted by:	Raphaël Doursenaud (rdoursenaud)		Submitted on:	17/11/2014 20:48
Last Modified On:	24/11/2014 12:46
Summary:	Don't think the ID should be displayed in holiday module
Description:	http://***/holiday/define_holiday.php The first column ID is an implementation detail and should not be displayed.
Step to reproduce bug:
Detected in version:	develop		Category:	Module: Holidays
Severity:	1 - Minor		OS Type/Version:
PHP version:			Database type and version:
Etat
Status:	Closed		Assigned to:	Marcos García (marcosgdf)
Resolution:	Fixed

Commentaires

Raphaël Doursenaud 28/11/2014 17:16

Thanks!

Marcos García 24/11/2014 12:46

The bug has been corrected. Pull request send inside GIT sources
(http://www.github.com/Dolibarr/dolibarr) and waiting to merge
into develop branch.

Marcos García 24/11/2014 12:40

Oh, sorry. I thought you were talking about other ID. You are right.

Raphaël Doursenaud 24/11/2014 11:41

The ID in the first reported list is directly linked to the user in the next column. It clearly is an implementation detail and not a reference.
For the log page, I agree it can be considered a reference but then it should be named accordingly. ID doesn't mean anything in french and most languages ;)

Marcos García 23/11/2014 16:20

Hi again. The ID is the number of the request... Like a "ref". There must be an indicator of every petition and I think the ID fits right here...

Raphaël Doursenaud 18/11/2014 11:19

Hi Marcos. I didn't review this module thoroughly until this time, so it slipped away.
I still believe that an implementation detail creeping away in UI is a defect, not a feature request.

Marcos García 17/11/2014 22:50

Hi Raphaël,

The ID is being displayed since 3.5 if I remember it righ, maybe this is not a bug but an enhancement...

Raphaël Doursenaud 17/11/2014 20:49

The same applies for the log at http://***/holiday/view_log.php

 Lien direct vers l'artefact  |  Mettre à jour vos préférences