Re: [dmidecode] [PATCH 3/3] Add new slot characteristics2 from SMBIOS spec 3.4.0

[Jean Delvare]

On Mon, 19 Oct 2020 08:39:12 +0530, Prabhakar pujeri wrote:
> * The bit to indicate PCIe surprise removal support.
> * The bit to indicate Flexbus CXL 1.0 version.
> * The bit to indicate Flexbus CXL 2.0 version.
> ---
>  dmidecode.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/dmidecode.c b/dmidecode.c
> index 335a6bb..33162cb 100644
> --- a/dmidecode.c
> +++ b/dmidecode.c
> @@ -2118,7 +2118,10 @@ static void dmi_slot_characteristics(const char *attr, 
> u8 code1, u8 code2)
>               "PME signal is supported", /* 0 */
>               "Hot-plug devices are supported",
>               "SMBus signal is supported",
> -             "PCIe slot bifurcation is supported" /* 3 */
> +             "PCIe slot bifurcation is supported",
> +             "Slot supports async/surprise removal",
> +             "Flexbus slot, CXL 1.0 capable",
> +             "Flexbus slot, CXL 2.0 capable" /* 6 */
>       };
>  
>       if (code1 & (1 << 0))
> @@ -2133,7 +2136,7 @@ static void dmi_slot_characteristics(const char *attr, 
> u8 code1, u8 code2)
>               for (i = 1; i <= 7; i++)
>                       if (code1 & (1 << i))
>                               pr_list_item("%s", characteristics1[i - 1]);
> -             for (i = 0; i <= 3; i++)
> +             for (i = 0; i <= 6; i++)
>                       if (code2 & (1 << i))
>                               pr_list_item("%s", characteristics2[i]);
>               pr_list_end();

Applied, thanks. I took the liberty to reword bit 4 a little, to be
more in line with the other descriptions.

-- 
Jean Delvare
SUSE L3 Support