Re: [dmidecode] [PATCH] Add new memory device types from SMBIOS spec 3.4.0

[Jean Delvare]

Hi Prabhakar,

On Thu, 15 Oct 2020 16:34:16 +0530, Prabhakar pujeri wrote:
> Added 2 more new values (0x22 and 0x23).
> ---
>  dmidecode.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/dmidecode.c b/dmidecode.c
> index cd2b5c9..55b2336 100644
> --- a/dmidecode.c
> +++ b/dmidecode.c
> @@ -2639,7 +2639,9 @@ static const char *dmi_memory_device_type(u8 code)
>               "LPDDR4",
>               "Logical non-volatile device",
>               "HBM",
> -             "HBM2" /* 0x21 */
> +             "HBM2", 
> +    "DDR5",
> +    "LPDDR5" /* 0x23 */

Indentation is obviously incorrect here. Please use the same level of
indentation as the other lines have. Please note that the primary
indentation is done using tabs, not spaces, in the dmidecode project.

>       };
>  
>       if (code >= 0x01 && code <= 0x21)

This test needs to be updated too, otherwise your change above has no
effect.

Thanks,
-- 
Jean Delvare
SUSE L3 Support