Re: [dmidecode] [V2 PATCH] Fix System Slot Information for PCIe SSD

[Jean Delvare]

Hi Prabhakar,

On Mon, 14 Oct 2019 04:18:38 +0000, address@hidden wrote:
> dmidecode tool output for type 9 table show <out of spec> for PCIe SSD and
> SMBIOS spec table 48 describe  2.5" and 3.5" PCIe SSD
> 
> Signed-off-by: Prabhakar pujeri <address@hidden>
> ---
>  dmidecode.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/dmidecode.c b/dmidecode.c
> index aef18f8..f210969 100644
> --- a/dmidecode.c
> +++ b/dmidecode.c
> @@ -1906,10 +1906,12 @@ static const char *dmi_slot_length(u8 code)
>     "Other", /* 0x01 */
>     "Unknown",
>     "Short",
> -   "Long" /* 0x04 */
> +   "Long",
> +    "2.5\" drive form factor",
> +   "3.5\" drive form factor" /* 0x06 */
>   };
> 
> - if (code >= 0x01 && code <= 0x04)
> + if (code >= 0x01 && code <= 0x06)
>     return length[code - 0x01];
>   return out_of_spec;
>  }

Patch is mangled, so it doesn't apply. I'll fix it manually this time
because it's a small patch, but for future submissions, please teach
your email client to preserve white space. If you can't get it to do
that, then attach the patch instead of including it in the body.

Thanks,
-- 
Jean Delvare
SUSE L3 Support