dmidecode-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[dmidecode] [PATCH] dmidecode: Fix warnings about comparison between sig


From: Jean Delvare
Subject: [dmidecode] [PATCH] dmidecode: Fix warnings about comparison between signed and unsigned integers
Date: Mon, 4 May 2015 13:47:04 +0200

Fix warnings about comparison between signed and unsigned integers.
---
 dmidecode.c |   15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

--- a/dmidecode.c
+++ b/dmidecode.c
@@ -4412,12 +4412,13 @@ static void dmi_table_decode(u8 *buf, u3
 
                /* look for the next handle */
                next = data + h.length;
-               while (next - buf + 1 < len && (next[0] != 0 || next[1] != 0))
+               while ((unsigned long)(next - buf + 1) < len
+                   && (next[0] != 0 || next[1] != 0))
                        next++;
                next += 2;
                if (display)
                {
-                       if (next - buf <= len)
+                       if ((unsigned long)(next - buf) <= len)
                        {
                                if (opt.flags & FLAG_DUMP)
                                {
@@ -4451,11 +4452,11 @@ static void dmi_table_decode(u8 *buf, u3
                if (num && i != num)
                        printf("Wrong DMI structures count: %d announced, "
                                "only %d decoded.\n", num, i);
-               if (data - buf > len
-                || (num && data - buf < len))
-                       printf("Wrong DMI structures length: %d bytes "
-                               "announced, structures occupy %d bytes.\n",
-                               len, (unsigned int)(data - buf));
+               if ((unsigned long)(data - buf) > len
+                || (num && (unsigned long)(data - buf) < len))
+                       printf("Wrong DMI structures length: %u bytes "
+                               "announced, structures occupy %lu bytes.\n",
+                               len, (unsigned long)(data - buf));
        }
 }
 


-- 
Jean Delvare
SUSE L3 Support



reply via email to

[Prev in Thread] Current Thread [Next in Thread]