[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [dmidecode] dmidecode should omit warning about SMBIOS version when
Re: [dmidecode] dmidecode should omit warning about SMBIOS version when -q is set
Wed, 19 Mar 2014 18:45:25 +0100
On Mon, Mar 17, 2014 at 01:58:40PM +0100, Anton Arapov wrote:
> On Mon, Mar 17, 2014 at 10:24:45AM +0100, Jens Rosenboom wrote:
> > Am 16.03.14 16:36, schrieb Petter Reinholdtsen:
> > > [Jens Rosenboom]
> > >> As in particular scripts call dmidecode often with -s (implying -q)
> > >> and expect to get only a single word (and in particular only a
> > >> single line of output), I propose that in this case the warning
> > >> about an unsupported SMBIOS version should be ommited. Most scripts
> > >> won't be able to handle the warning properly anyway, also most -s
> > >> options should still continue to work. My patch would look like
> > >> this:
> > > What about sending the warning to stderr instead? This way scripts
> > > looking on stdin will not notice, while the info is still emitted.
> > Would be fine for me.
> It's not an error message, it's INFO message. All the error
> messages are already routed to stderr. This very message is
> intentionally left to stdout because it IS important. And it can be
> easily filtered out in a shell scripts.
> The message is important because we can't guarantee the output is
> correct in that case. If we suppress it we might be getting reports of
> the wrong information interpretation. IOW users will complaint about
> all kind of weirdness dmidecode might show them when use new hardware.
> I am not going to fix it. :)
And I forgot to mention:
See the commit:
I've added it a while back to address exactly this situation.
Re: [dmidecode] dmidecode should omit warning about SMBIOS version when -q is set, Erwan Velu, 2014/03/17