Re: theme work in progress

[Riccardo Canalicchio]

Fred, about a patch...

I'm working on the NSToolbar, my intent is to integrate the toolbar into the window titlebar like this:

https://dl.dropboxusercontent.com/u/3470013/theme/toolbar.png

The best would be to draw the titlebar with the height increased by the [toolbarview _heightFromLayout], 

currently GSTheme expose only one method: titlebarHeight, and seems like the toolbar uses this method to find its position

I have made some hacks to make it works but I would like to find a generic solution that could work even if the theme would like a separate nstoolbar..

If this make sense to you, I'm open to suggestions on how could be the right way to do

On 22 December 2013 14:12, Riccardo Canalicchio <riccardo.canalicchio@gmail.com> wrote:

thanks David!

On 22 December 2013 14:00, David Chisnall <theraven@sucs.org> wrote:

It looks like a nice start.  A few comments:

- The knob on sliders is drawn slightly too large, so the circle is clipped

yes i know... need to fix this

- The scroll bars look a bit ugly - in particular, the buttons are tiny and difficult to hit.  Mind you, scrollers on recent versions of OS X are pretty hideous too...

 

yes in the recent osx scroller buttons are gone... 

The table view headers and the colour well have not been done yet, I think.  The stepper doesn't seem to have the arrows quite in the centre.

 

TODO 

With the Mac menu bar style, there's still a bug where the menu appears slightly too low and then jumps to the correct position if you move the mouse to the top (not the fault of the theme, I think), but aside from that the menus look very nice.

 

not finished yet.. 

I'd prefer a coloration that gave a bit more visual distinction between clickable and non-clickable things - the buttons are almost the same colour as the background, which makes them a bit indistinct.

 

I will keep this in mind...

I'm looking forward to the final version,

David

On 22 Dec 2013, at 12:39, Riccardo Canalicchio <riccardo.canalicchio@gmail.com> wrote:

> Thanks Fred, for looking at it,
> my intent is to finish the theme and then discuss with you guys, if some patches are possible and if they makes sense...
>
>
>
> On 22 December 2013 13:23, Fred Kiefer <fredkiefer@gmx.de> wrote:
> On 22.12.2013 11:29, Riccardo Canalicchio wrote:
> > Hi There,
> > I would like to share with you my work in progress theme...
> > I'm working on it from about 2 weeks... the intent of this theme is to make
> > a gui similar to osx maverick. I have choosen to draw things
> > programmatically... I have seen that there is a big work to make the gui
> > themable using images but my intent is to use this theme to study the
> > gnustep internals so I have choose the hard way...
> > the git repository of the theme is here:
> > https://github.com/nongio/rik.theme
> > * the icons are from Meliae GNOME Icon sets developed by Sora:
> > http://sora-meliae.deviantart.com/art/Meliae-SVG-Icon-Theme-v-1-2-151155215
> >
> > it's probably bugged and not complete at the moment... if anyone would like
> > to help me is welcome!
>
> I looked at the code of this theme and that seems quite nice. It also
> shows that we have come a long way with themes, a lot is already
> possible but there are still places where theme support in GNUstep is
> limited. It should be possible to have themes for window decoration
> without actually touching the code of NSWindow and
> GSStandardDecorationView. If you have suggestions on how to improve
> this, patches are welcome.
>
> Fred
>
>
>
> _______________________________________________
> Discuss-gnustep mailing list
> Discuss-gnustep@gnu.org
> https://lists.gnu.org/mailman/listinfo/discuss-gnustep
>
> _______________________________________________
> Discuss-gnustep mailing list
> Discuss-gnustep@gnu.org
> https://lists.gnu.org/mailman/listinfo/discuss-gnustep

-- Sent from my STANTEC-ZEBRA