discuss-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Problems with GNUMail or GSDecorationView?


From: Riccardo Mottola
Subject: Re: Problems with GNUMail or GSDecorationView?
Date: Thu, 20 Aug 2009 23:27:16 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.22) Gecko/20090805 SeaMonkey/1.1.17

Hi Tim,

good thing that we have an "official" response, after our hacking together on this. Please send a note to Ludovic. It would be very nice if he could release a new tarball (even if beta) with this change so people can continue to use GNUMail and distributions canupgrade.

Riccardo

Tim Kack wrote:
Thanks, a [[self window] setDelegate: nil] in -dealloc of the controller solved it.

Best regards,
Tim

On 2009-08-19 10:56:18 +0200 Richard Frith-Macdonald <richard@tiptree.demon.co.uk> wrote:


On 19 Aug 2009, at 09:38, Tim Kack wrote:

Note, at this point _delegate will be 0xdeadface because the EditWindowController has been deallocated and therefore respondsToSelector will crash.

Now, my question is - is this a GNUMail bug (i.e. the NSToolbar should have been deallocated earlier) or is it a problem with the GSWindowDecorationView removeToolbarView? Perhaps there should be a check if the delegate still is valid before calling setFrame?

I'm not really familiar with the code concerned, but from your description it sounds like the bug is in EditWindowController

If EditWindowController has set itsself as the delegate for a window, it should also have removed itsself as the delegate at the start of its -dealloc method. It's a firm rule that an object must remove itsself as a delegate of any other object before it deallocates itsself.




_______________________________________________
Discuss-gnustep mailing list
Discuss-gnustep@gnu.org
http://lists.gnu.org/mailman/listinfo/discuss-gnustep






reply via email to

[Prev in Thread] Current Thread [Next in Thread]