discuss-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: NSDocument fix


From: Fred Kiefer
Subject: Re: NSDocument fix
Date: Mon, 01 Oct 2007 21:27:22 +0200
User-agent: Thunderbird 1.5.0.12 (X11/20060911)

Wolfgang Lux wrote:
> Hello list!
> 
> The following patch improves my previous fix to the -fileName/-setFileName:
> compatibility code in NSDocument. The patch now ensures that the document's
> URL is nil if the file name is nil. Note that NSDocument uses [self
> fileURL]
> in a few places and checks whether the result is nil or not nil. In
> addition,
> the attached patch removes an unnecessary call to
> -setLastComponentOfFileName:
> in method -setFileName: (-setFileURL: takes care of this already) and fixes
> one place where the local error variable was not assigned in the correct
> place in method
> -writeToURL:ofType:forSaveOperation:originalContentsURL:error:
> 

I committed these changes and the one to NSWindow.

Thank you!
Fred




reply via email to

[Prev in Thread] Current Thread [Next in Thread]