Re: NSMatrix, NSCell, NSBrowser,NSBrowserCell proposed patch

[Fred Kiefer]

Sergii Stoian wrote:
> Forgot to attach files.
> 

Hi Sergii,

I already commit my part of the change. Please give it a try.

I don't thing that your proposed change to setShowsFirstResponder: is
correct. That way we don't have a chance to store the focus type. It
will get overridden each time this method is called. This would defy the
idea that I explained in my previous mail, where you could just set the
focus type for the browser cells to NSFocusRingTypeNone.

As for the NSMatrix change I am also surprised by the code duplication
there. But your change looks dangerous. I would expect that for an
NSMatrix not drawing its background, we run into an infinit loop with
that change.

Cheers,
Fred