Re: cosmetic patches for gui

[Fred Kiefer]

Should be in SVN now.

Ingolf Jandt schrieb:
> Hello Folks!
> There are some ugly boxes around texts when windowBackgroundColor !=
> controlBackgroundColor. The following (trivial) changes make them
> disappear.
> Have a nice day!
> Ingolf
> 
> 
> <GSPrintPanel.gorm.zip> -- turned off "draws background" for box titles,
> moved things a few pixels for better alignment.
> <GSPageLayout.gorm.zip> --  turned off "draws background" for radio
> button matrix
> 
> 
> <NSTabView.m.diff><NSTabViewItem.m.diff> -- draw tab background with
> window background color
> <NSAlert.m.diff> -- draw message text background with window background
> color
> 
> 
> ------------------------------------------------------------------------
> 
> Index: NSTabView.m
> ===================================================================
> --- NSTabView.m       (Revision 24411)
> +++ NSTabView.m       (Arbeitskopie)
> @@ -432,7 +432,7 @@
>             iP.x = aRect.origin.x;
>             iP.y = aRect.origin.y;
>             
> -           [[NSColor controlBackgroundColor] set];
> +           [[NSColor windowBackgroundColor] set];
>  
>             if (itemState == NSSelectedTab)
>               {
> @@ -477,7 +477,7 @@
>             iP.x = previousRect.origin.x + previousRect.size.width;
>             iP.y = aRect.origin.y;
>             
> -           [[NSColor controlBackgroundColor] set];
> +           [[NSColor windowBackgroundColor] set];
>  
>             if (itemState == NSSelectedTab) 
>               {
> @@ -538,7 +538,7 @@
>           {
>             iP.x += s.width + 13;
>  
> -           [[NSColor controlBackgroundColor] set];
> +           [[NSColor windowBackgroundColor] set];
>  
>             if ([anItem tabState] == NSSelectedTab)
>               {
> @@ -579,7 +579,7 @@
>             iP.x = aRect.origin.x;
>             iP.y = aRect.size.height;
>  
> -           [[NSColor controlBackgroundColor] set];
> +           [[NSColor windowBackgroundColor] set];
>             
>             if (itemState == NSSelectedTab)
>               {
> @@ -618,7 +618,7 @@
>             iP.x = previousRect.origin.x + previousRect.size.width;
>             iP.y = aRect.size.height;
>             
> -           [[NSColor controlBackgroundColor] set];
> +           [[NSColor windowBackgroundColor] set];
>  
>             if (itemState == NSSelectedTab)
>               {
> @@ -671,7 +671,7 @@
>           {
>             iP.x += s.width + 13;
>             
> -           [[NSColor controlBackgroundColor] set];
> +           [[NSColor windowBackgroundColor] set];
>           
>             if ([anItem tabState] == NSSelectedTab)
>               {             
> 
> 
> ------------------------------------------------------------------------
> 
> Index: NSTabViewItem.m
> ===================================================================
> --- NSTabViewItem.m   (Revision 24411)
> +++ NSTabViewItem.m   (Arbeitskopie)
> @@ -179,17 +179,17 @@
>      {
>        fRect.origin.y -= 1;
>        fRect.size.height += 1;
> -      [[NSColor controlBackgroundColor] set];
> +      [[NSColor windowBackgroundColor] set];
>        NSRectFill(fRect);
>      }
>    else if (_state == NSBackgroundTab)
>      {
> -      [[NSColor controlBackgroundColor] set];
> +      [[NSColor windowBackgroundColor] set];
>        NSRectFill(fRect);
>      }
>    else
>      {
> -      [[NSColor controlBackgroundColor] set];
> +      [[NSColor windowBackgroundColor] set];
>      }
>  
>    attr = [[NSDictionary alloc] initWithObjectsAndKeys: 
> 
> 
> ------------------------------------------------------------------------
> 
> Index: NSAlert.m
> ===================================================================
> --- NSAlert.m (Revision 24411)
> +++ NSAlert.m (Arbeitskopie)
> @@ -406,7 +406,7 @@
>    */
>    [messageField setBezeled: NO];
>    [messageField setDrawsBackground: YES];
> -  [messageField setBackgroundColor: [NSColor controlBackgroundColor]];
> +  [messageField setBackgroundColor: [NSColor windowBackgroundColor]];
>    [messageField setAlignment: NSCenterTextAlignment];
>    [messageField setStringValue: @""];
>    [messageField setFont: MessageFont];
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Discuss-gnustep mailing list
> Discuss-gnustep@gnu.org
> http://lists.gnu.org/mailman/listinfo/discuss-gnustep