Re: the gnustep wreckage. Part 1: windowmaker and user apps

[Matt Rice]

--- Riccardo <multix@ngi.it> wrote:
<snip>

> windowmaker 0.91 (out of the NetBSD ports tree) +
> latest gnustep CVS 
> seem to have trouble. I use -xlib
> 
> 1. focus! damn! it makes me go crazy. The worst part
> are menus. They 
> layer from e wrong application, pop-up unwanted from
> the application 
> behind... or selecting a submenu may make disappear
> the main menu while 
> opening the submenu...
> 

this is a problem with windowmaker 0.9x attached is a
patch. (already in route to the wm-dev list)


windowmaker is ignoring requests for focus from menus,
so if a menu is the last window on screen
windowmaker would focus the next focused window (not
from the active app) and the app would deactivate when
that window took focus.




                
__________________________________ 
Do you Yahoo!? 
The all-new My Yahoo! - Get yours free! 
http://my.yahoo.com 
 

diff -Naur ./WindowMaker-0.91.0/src/switchmenu.c 
WindowMaker-0.91.0.mod2/src/switchmenu.c
--- ./WindowMaker-0.91.0/src/switchmenu.c       2004-10-18 19:41:54.000000000 
-0700
+++ WindowMaker-0.91.0.mod2/src/switchmenu.c    2004-11-22 03:56:48.540567984 
-0800
@@ -231,7 +231,11 @@
         char *t;
         int idx;
 
-        if (wwin->flags.internal_window || WFLAGP(wwin, skip_window_list))
+        if (wwin->flags.internal_window || WFLAGP(wwin, skip_window_list) 
+           || ((wwin->wm_gnustep_attr 
+               && wwin->wm_gnustep_attr->flags & GSWindowLevelAttr) 
+               && (wwin->wm_gnustep_attr->window_level  == 
WMMainMenuWindowLevel
+                   || wwin->wm_gnustep_attr->window_level == 
WMSubmenuWindowLevel)))
             return;
 
         if (wwin->frame->title)
diff -Naur ./WindowMaker-0.91.0/src/window.c 
WindowMaker-0.91.0.mod2/src/window.c
--- ./WindowMaker-0.91.0/src/window.c   2004-10-22 20:11:10.000000000 -0700
+++ WindowMaker-0.91.0.mod2/src/window.c        2004-11-22 03:56:48.540567984 
-0800
@@ -340,17 +340,6 @@
         wwin->client_flags.no_appicon = 1;
     }
 
-    /* temporary solution to avoid GS menus in our window list.
-     * it's temporary because it's not the proper way: windows at the
-     * floating level are also skipped from the window list with this.
-     * Fix it -Dan */
-    if (gs_hints->flags & GSWindowLevelAttr) {
-        if (gs_hints->window_level == WMMainMenuWindowLevel ||
-            gs_hints->window_level == WMSubmenuWindowLevel) {
-            wwin->client_flags.skip_window_list = 1;
-        }
-    }
-
 }