Re: Bug in gui 0.9.2 (NSImage::size)

[David Ayers]

Andreas Höschler wrote:
> Hi all,
>
> I found a bug in the latest gui. I get an "Illegal Instruction (core 
> dumped)" in NSImage.m
>
> - (NSSize) size
> {
>   if (_size.width == 0)
>     {
>         NSLog(@"size A");
>       NSImageRep *rep = [self bestRepresentationForDevice: nil];
>         NSLog(@"size B %@", rep);
>       _size = [rep size];    // <-- core dumped is raised here
>         NSLog(@"size C");
>     }
>   return _size;
> }
>
> -bestRepresentationForDevice returns nil in my case. Then [rep size] is 
> called which is not a good idea. Bummh!!! I haven't looked too much into 
> NSImage yet and whether one should expect  bestRepresentationForDevice 
> to return nil. If anybody immediately knows what's wrong here I would be 
> glad for a pointer.

NSSize is a structure but the method to nil returns nil.

the fix would be:

...
if (rep != nil)
  {
    _size = [rep size];
  }
...

But I currently have other issues so I can't commit the fix right now. 
Unless someone beats me to it I'll try to do it later today.

Cheers,
David