Re: [Denemo-devel] Problems with the window installer. Re: [bug #45956] Installer deletes system path.

[Richard Shann]

On Sat, 2015-09-19 at 09:45 -0500, Jeremiah Benham wrote:
> I have a new binary for testing. I took the old 1.2.2. nsi file and
> replaced the function (now I know it might not need replacing as you
> said)

I've installed this on a windows vista laptop after first uninstalling
the earlier version, deleting the fonts denemo.ttf, feta*.ttf and
emmentaler*.ttf and the ~/.denemo-*
The program worked all fonts were found *and* the PATH environment
variable had not been altered (denemo does not appear in it after
installing, and the original contents are unchanged).

So, all good news. However, I re-tested the bug that happens if you use
the window decorations "x" to dismiss the dialog asking for the title of
your piece, and it caused Denemo to crash. These decorations don't
appear on my system (they are a theme thing I suspect). On the plus
side, I think I have got to the bottom of this, and have checked in a
fix which I hope will work on windows too.

So if you can spin another binary I'll test this out.

Richard


> 
> Jeremiah
> 
> On Sep 19, 2015 5:44 AM, "Richard Shann" <address@hidden>
> wrote:
>         Ah, this goes quite a way to explaining what is going on - I
>         think I'll
>         have to make sure I not only remove .denemo-x.x.x before
>         trying a new
>         install, but also delete feta*.ttf, emmentaler*.ttf and
>         Denemo.ttf from
>         the C:\Windows\Fonts directory, as they are left there after
>         installing
>         a previous version.
>         This also may mean that you have no need to try the fix to
>         denemo.nsi,
>         that, in fact, all will be working ok once denemo.nsi has the
>         functionality it had pre 1.2.4 (I know of at least one Windows
>         8 user
>         who installed the 1.2.4 successfully, presumably because the
>         fonts had
>         already been installed by earlier versions).
>         
>         Richard
>         
>         
>         On Fri, 2015-09-18 at 12:32 -0500, Jeremiah Benham wrote:
>         > I have been trying to attempt to merge our old stuff in gub
>         with the
>         > new stuff that is being developed upstream. In doing this I
>         failed I
>         > mixed this denemo.nsi file with an extremely old version and
>         I did not
>         > know it. This may have been what was causing some issue. I
>         replaced
>         > the denemo.nsi to be the one used before the 1.2.4 release
>         and made
>         > the changes to the binary. I am updating the binary now.
>         >
>         >
>         > Jeremiah
>         >
>         >
>         > On Mon, Sep 14, 2015 at 7:11 AM, Richard Shann
>         > <address@hidden> wrote:
>         >         Jeremiah,
>         >         I think there is something we could try to improve
>         the windows
>         >         installer.
>         >         In
>         https://github.com/jjbenham/gub/blob/master/nsis/denemo.nsi
>         >
>         >         there is this function:
>         >
>         >         Function postinstall_denemo
>         >                 CopyFiles /silent "$INSTDIR\usr\share\fonts
>         \truetype
>         >         \denemo\Denemo.ttf" "$WINDIR\Fonts\Denemo.ttf"
>         >                 StrCpy $FONT_DIR "$WINDIR\Fonts"
>         >                 !insertmacro InstallTTFFont "${ROOT}\usr
>         \share\fonts
>         >         \truetype\denemo\Denemo.ttf"
>         >                 CopyFiles /silent "$INSTDIR\usr\share\fonts
>         \truetype
>         >         \denemo\feta.ttf" "$WINDIR\Fonts\feta.ttf"
>         >                 !insertmacro InstallTTFFont "${ROOT}\usr
>         \share\fonts
>         >         \truetype\denemo\feta.ttf"
>         >                 CopyFiles /silent "$INSTDIR\usr\share\fonts
>         \truetype
>         >         \denemo\emmentaler.ttf" "$WINDIR\Fonts
>         \emmentaler.ttf"
>         >                 !insertmacro InstallTTFFont "${ROOT}\usr
>         \share\fonts
>         >         \truetype\denemo\emmentaler.ttf"
>         >                 ClearErrors
>         >         FunctionEnd
>         >
>         >         I think this may have stopped working with some
>         versions of
>         >         windows:
>         >         When I manually drag feta.ttf to the $WINDIR\Fonts\
>         directory
>         >         windows
>         >         actually changes the name to feta25.2.ttf and the
>         >         emmentaler.ttf is
>         >         renamed to Emmentaler-26.ttf
>         >
>         >         So it may be that replacing that version of
>         postinstall_denemo
>         >         with this
>         >         will work:
>         >
>         >         Function postinstall_denemo
>         >                 CopyFiles /silent "$INSTDIR\usr\share\fonts
>         \truetype
>         >         \denemo\Denemo.ttf" "$WINDIR\Fonts\Denemo.ttf"
>         >                 StrCpy $FONT_DIR "$WINDIR\Fonts"
>         >                 !insertmacro InstallTTFFont "${ROOT}\usr
>         \share\fonts
>         >         \truetype\denemo\Denemo.ttf"
>         >                 CopyFiles /silent "$INSTDIR\usr\share\fonts
>         \truetype
>         >         \denemo\feta.ttf" "$WINDIR\Fonts\feta25.2.ttf"
>         >                 !insertmacro InstallTTFFont "${ROOT}\usr
>         \share\fonts
>         >         \truetype\denemo\feta.ttf"
>         >                 CopyFiles /silent "$INSTDIR\usr\share\fonts
>         \truetype
>         >         \denemo\emmentaler.ttf" "$WINDIR\Fonts
>         \Emmentaler-26.ttf"
>         >                 !insertmacro InstallTTFFont "${ROOT}\usr
>         \share\fonts
>         >         \truetype\denemo\emmentaler.ttf"
>         >                 ClearErrors
>         >         FunctionEnd
>         >
>         >
>         >         Though why there should be both the CopyFiles
>         command and the
>         >         InstallTTFont procedure run I don't understand.
>         >
>         >         Could you try this out on a build of the mingw exe
>         installer?
>         >
>         >         The other puzzle is why the installer seems to be
>         adding to
>         >         the system
>         >         path environment variable, the function to do that
>         has been
>         >         commented
>         >         out for some years, but I can't quite trace all the
>         logic...
>         >
>         >         Richard
>         >
>         >         On Mon, 2015-09-14 at 09:32 +0000, Richard Shann
>         wrote:
>         >         > Update of bug #45956 (project denemo):
>         >         >
>         >         >                   Status:                    None
>         => Need
>         >         Info
>         >         >
>         >         >
>          _______________________________________________________
>         >         >
>         >         > Follow-up Comment #1:
>         >         >
>         >         > I have installed it on a windows Vista machine,
>         the Denemo
>         >         path appears
>         >         > appended to another path - in fact appended twice
>         because, I
>         >         presume of an
>         >         > earlier install. The irony is that Denemo does not
>         use the
>         >         path at all, I've
>         >         > deleted it from the path and Denemo continues to
>         work fine.
>         >         > What did happen on this install was that the
>         feta.ttf and
>         >         emmentaler.ttf fonts
>         >         > were not intalled - I copied them to the C:
>         \Windows\Fonts
>         >         directory and all
>         >         > worked.
>         >         > Very bizarrely, on copying them to that directory,
>         windows
>         >         looked inside the
>         >         > font file, extracted the internal name of the font
>         and
>         >         re-named the files to
>         >         > be the actual name of the font.
>         >         >
>         >         > What version of Windows did you have that
>         experience - and
>         >         are you quite sure
>         >         > that there was something in the path that got
>         erased?
>         >         > Try altering the Denemo path that is there to say
>         XXXDenemo
>         >         and then
>         >         > re-installing. Does it append?
>         >         >
>         >         >
>          _______________________________________________________
>         >         >
>         >         > Reply to this item at:
>         >         >
>         >         >   <http://savannah.gnu.org/bugs/?45956>
>         >         >
>         >         > _______________________________________________
>         >         >   Message sent via/by Savannah
>         >         >   http://savannah.gnu.org/
>         >         >
>         >
>         >
>         >
>         >         _______________________________________________
>         >         Denemo-devel mailing list
>         >         address@hidden
>         >         https://lists.gnu.org/mailman/listinfo/denemo-devel
>         >
>         >
>         
>