Re: [Denemo-devel] Release 1.1.6

[Richard Shann]

On Wed, 2014-05-28 at 09:23 -0500, Jeremiah Benham wrote:
> Now failing here:
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:331:
>  error: 'GTK_STATE_FLAG_FOCUSED' undeclared (first use in this function)
> 
> Surely I can look that up but I will need to do that later. I guess
> its just a reminder that we need to have a solution for mingw gtk3
> builds. I can compile an early version of gtk3 with gub for mingw but
> we had problems with evince not loading the backend. I did build a
> version of gtk3 in mxe but I need to write a test for it. I am not
> sure if it works or not.

Well it certainly would be good not to have to continue supporting gtk2,
but it would be a shame to hold up releasing new features because of the
difficulties in building for windows.
Shall I put in some conditional code for these gtk3-isms, they must be
very, very, few (in fact, I expect you have found both of them already)?

Richard


> 
> 
> Jeremiah
> 
> 
> 
> On Mon, May 26, 2014 at 11:36 AM, Richard Shann
> <address@hidden> wrote:
>         
>         Hmm, I guess you still have GTK2 on mingw? I see that the
>         typedef for GdkRGBA is quite simple:
>         
>         typedef struct {
>           gdouble red;
>           gdouble green;
>           gdouble blue;
>           gdouble alpha;
>         } GdkRGBA;
>         
>         perhaps it might be enough to include this for the windows
>         build, we could have a
>         
>         #if GTK_MAJOR_VERSION==2
>                 typedef struct {
>                   gdouble red;
>                   gdouble green;
>                   gdouble blue;
>                   gdouble alpha;
>                 } GdkRGBA;
>         #endif
>         
>         I've tested this syntax, though there may be further GTK3-isms
>         to be
>         found, if you can build on GNU/Linux against GTK2 that may
>         save more
>         iterations.
>         
>         Richard
>         
>         
>         On Mon, 2014-05-26 at 11:10 -0500, Jeremiah Benham wrote:
>         > I am getting these errors when compiling for mingw:
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:
>  In function 'add_verse_to_staff':
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:320:
>  error: 'GdkRGBA' undeclared (first use in this function)
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:320:
>  error: (Each undeclared identifier is reported only once
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:320:
>  error: for each function it appears in.)
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:320:
>  error: expected ';' before 'grayed'
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:321:
>  error: expected ';' before 'white'
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:322:
>  error: 'GTK_STATE_FLAG_FOCUSED' undeclared (first use in this function)
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:322:
>  error: 'white' undeclared (first use in this function)
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:323:
>  error: 'GTK_STATE_FLAG_NORMAL' undeclared (first use in this function)
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:323:
>  error: 'grayed' undeclared (first use in this function)
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:
>  In function 'add_verse':
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:338:
>  warning: passing argument 1 of 'gtk_widget_show' from incompatible pointer 
> type
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:
>  In function 'delete_verse':
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:356:
>  warning: passing argument 1 of 'gtk_widget_get_parent' from incompatible 
> pointer type
>         > 
> /home/jjbenham/public_html/gub/target/mingw/src/denemo-1.1.6/src/command/lyric.c:
>  In function 'reset_lyrics':
>         >
>         >
>         >
>         >
>         > On Mon, May 26, 2014 at 7:25 AM, Jeremiah Benham
>         > <address@hidden> wrote:
>         >         ok. I'm starting to build the binaries now.
>         >
>         >         Jeremiah
>         >
>         >         On May 26, 2014 3:40 AM, "Richard Shann"
>         >         <address@hidden> wrote:
>         >                 I see the stable-1.1.6 branch now, I have
>         checked it
>         >                 out and (thanks to
>         >                 Andreas Schneider) managed to get make dist
>         to work.
>         >                 So I have uploaded
>         >                 the tarball generated by this to
>         >
>         >
>         http://www.denemo.org/~rshann/denemo-1.1.6.tar.gz
>         >
>         >                 as the candidate 1.1.6 source code release.
>         I'll send
>         >                 this to
>         >                 translationproject.org, meanwhile if you can
>         generate
>         >                 binaries for
>         >                 testing I will test them.
>         >
>         >                 Richard
>         >
>         >
>         >                 On Sun, 2014-05-25 at 21:55 +0100, Richard
>         Shann
>         >                 wrote:
>         >                 > On Sun, 2014-05-25 at 22:20 +0200, Éloi
>         Rivard
>         >                 wrote:
>         >                 > > Yes it does appear.
>         >                 >
>         >                 > In that case, Jeremiah, do you have time
>         to create a
>         >                 branch for 1.1.6
>         >                 > and a trial tarball?
>         >                 >
>         >                 > Richard
>         >                 >
>         >                 >
>         >                 >
>         >                 >
>         _______________________________________________
>         >                 > Denemo-devel mailing list
>         >                 > address@hidden
>         >                 >
>         https://lists.gnu.org/mailman/listinfo/denemo-devel
>         >
>         >
>         >
>         >
>         
>         
>         
> 
>