Re: [Denemo-devel] Compiling with -Werror=format-security

[Richard Shann]

On Sat, 2014-03-08 at 14:19 +0100, Andreas Schneider wrote:
> More in scorelayouts.c

I fixed these, then ran with -Wformat -Werror=format-security and fixed
others, so the default build is now clean I think.
Let me know if you find something in optional code.
Richard


> 
> gcc -DHAVE_CONFIG_H -I. -I..    -I../intl -I../include
> -I../libs/libsffile -I../pixmaps -DPREFIX=\"/usr\" -DBINDIR=\"/usr/bin\"
> -DLOCALEDIR=\"/usr/share/locale\" -DSYSCONFDIR=\"/etc/denemo/\"
> -DPKGDATADIR=\"/usr/share/denemo/\" -DDATAROOTDIR=\"/usr/share/\"
> -DPKGNAME=\"denemo\" -DG_LOG_DOMAIN=\"Denemo\"  -D_FORTIFY_SOURCE=2  -g
> -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat
> -Werror=format-security     -D_WITH_AUBIO_4_ -I/usr/include/aubio
> -D_WITH_AUBIO_3_ -I/usr/include/libxml2   -pthread
> -I/usr/include/librsvg-2.0 -I/usr/include/glib-2.0
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
> -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/cairo
> -I/usr/include/libpng12 -I/usr/include/pixman-1 -I/usr/include/freetype2
>     -pthread -lgthread-2.0 -lrt -lglib-2.0   -lsndfile
> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
> -pthread -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0
> -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo
> -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2
> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
> -I/usr/include/pixman-1 -I/usr/include/libpng12   -pthread
> -I/usr/include/gtksourceview-3.0 -I/usr/include/libxml2
> -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0
> -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo
> -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2
> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
> -I/usr/include/pixman-1 -I/usr/include/libpng12   -pthread
> -I/usr/include/gtk-3.0 -I/usr/include/glib-2.0
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pango-1.0
> -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo
> -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2
> -I/usr/include/pixman-1 -I/usr/include/libpng12
> -I/usr/include/evince/3.0   -DUSE_EVINCE -D_HAVE_FLUIDSYNTH_
> -D_HAVE_RUBBERBAND_   -D_HAVE_PORTAUDIO_ -pthread     -D_HAVE_PORTMIDI_
> -D_HAVE_X11_ -c scorelayout.c
> scorelayout.c: In function ‘get_options_button’:
> scorelayout.c:567:3: warning: ‘gtk_hbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c: In function ‘create_voice_widget’:
> scorelayout.c:745:3: warning: ‘gtk_hbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:763:7: warning: ‘gtk_hbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c: In function ‘create_lyric_widget’:
> scorelayout.c:814:3: warning: ‘gtk_hbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c: In function ‘create_element’:
> scorelayout.c:945:3: warning: ‘gtk_hbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c: In function ‘install_pre_movement_widgets’:
> scorelayout.c:1087:3: warning: ‘gtk_vbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:1090:3: warning: ‘gtk_hbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c: In function ‘install_scoreblock_overrides’:
> scorelayout.c:1177:11: warning: ‘gtk_vbox_new’ is deprecated (declared
> at /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c: In function ‘install_staff_group_start’:
> scorelayout.c:1332:15: warning: ‘gtk_hbox_new’ is deprecated (declared
> at /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:1351:15: warning: ‘gtk_vbox_new’ is deprecated (declared
> at /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:1370:15: warning: ‘gtk_vbox_new’ is deprecated (declared
> at /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c: In function ‘get_movement_widget’:
> scorelayout.c:1513:3: warning: ‘gtk_vbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:1523:3: warning: ‘gtk_vbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:1550:7: warning: ‘gtk_hbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:1608:7: warning: ‘gtk_hbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:1617:7: warning: ‘gtk_vbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c: In function ‘create_misc_scorewide’:
> scorelayout.c:1738:3: warning: ‘gtk_vbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c: In function ‘create_scoreheader_directives’:
> scorelayout.c:1760:3: warning: ‘gtk_vbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c: In function ‘create_score_directives’:
> scorelayout.c:1791:3: warning: ‘gtk_vbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c: In function ‘create_scorewide_block’:
> scorelayout.c:1816:3: warning: ‘gtk_vbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c: In function ‘set_default_scoreblock’:
> scorelayout.c:1851:3: warning: ‘gtk_vbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:1872:11: warning: ‘gtk_hbox_new’ is deprecated (declared
> at /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:1881:11: warning: ‘gtk_vbox_new’ is deprecated (declared
> at /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:1887:11: warning: ‘gtk_vbox_new’ is deprecated (declared
> at /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:1889:11: warning: ‘gtk_hbox_new’ is deprecated (declared
> at /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:1898:15: warning: ‘gtk_vbox_new’ is deprecated (declared
> at /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:1919:15: warning: ‘gtk_vbox_new’ is deprecated (declared
> at /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c:1939:15: warning: ‘gtk_vbox_new’ is deprecated (declared
> at /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> scorelayout.c: In function ‘selection_layout’:
> scorelayout.c:2529:11: error: format not a string literal and no format
> arguments [-Werror=format-security]
> scorelayout.c: In function ‘get_scoreblock_for_lilypond’:
> scorelayout.c:2804:3: warning: ‘gtk_vbox_new’ is deprecated (declared at
> /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new'
> instead [-Wdeprecated-declarations]
> cc1: some warnings being treated as errors
> make[2]: *** [scorelayout.o] Fehler 1
> make[2]: Leaving directory `/home/src/denemo/src'
> 
> Andreas
> 
> _______________________________________________
> Denemo-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/denemo-devel