[Denemo-devel] [bug #41615] [smf_load.c:635]: (warning) Logical conjunction always evaluates to false: EXPR < 1 && EXPR > 9

[David Binderman]

URL:
  <http://savannah.gnu.org/bugs/?41615>

                 Summary: [smf_load.c:635]: (warning) Logical conjunction
always evaluates to false: EXPR < 1 && EXPR > 9
                 Project: Denemo
            Submitted by: dcb314
            Submitted on: Sun 16 Feb 2014 21:19:58 GMT
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:


Source code is

    if (event->midi_buffer[3] < 1 && event->midi_buffer[3] > 9)
        return (0);

Maybe

    if (event->midi_buffer[3] < 1 || event->midi_buffer[3] > 9)
        return (0);

would be better code.






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?41615>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/