Re: [Denemo-devel] Refactoring

[Richard Shann]

On Wed, 2013-11-06 at 15:50 +0100, Éloi Rivard wrote:
> I will focus on the refactor branch later, as you said.
> 
> The priority I think is to be able to run Denemo without a GUI so we
> can set up some tests that could be checked at each commit by Travis.
> 
> What about the scm field in actions ? (My sunday message)

There is a comment in view.c:5897

   Note that all such actions (that may be called back by scheme
directly in this fashion) are given the attribute "scm" with value 1; I
do not think this is being exploited in the code at present, and is
perhaps not needed.

I can't think of a situation in the code where you would have a
GtkAction and need to know if there was a corresponding scheme function
for executing the action; that is when you could use that, although you
could always ask guile. So it can go.

Richard



> 
> 
> 
> 2013/11/6 Richard Shann <address@hidden>
>         On Wed, 2013-11-06 at 14:57 +0100, Éloi Rivard wrote:
>         > Yes incremental search works too.
>         
>         
>         oh, that's very good news. I can try to test later - did you
>         still need
>         the branch "refactor" testing? I was unable to build that one
>         when I
>         tried and emailed about it...
>         Richard
>         
>         
>         >
>         >
>         >
>         > 2013/11/6 Richard Shann <address@hidden>
>         >         On Wed, 2013-11-06 at 14:38 +0100, Éloi Rivard
>         wrote:
>         >         > If have commited some changes on the branch
>         >         command-hash-table. Now in
>         >         > DenemoKeymap commands are stored in a hashmap and
>         no more in
>         >         a
>         >         > GtkListStore, and bindings are stored in a GList
>         instead of
>         >         in a
>         >         > GtkListStore. This should reduce a bit the
>         dependency toward
>         >         Gtk, so
>         >         > it is a first step to make denemo launch without
>         Gtk.
>         >         >
>         >         >
>         >         > For what I have seen I seems to work. Commands are
>         executed.
>         >         You can
>         >         > add and remove bindings in command manager etc.
>         >
>         >         Can you search for them incrementally. I am very
>         sorry, but I
>         >         meant to
>         >         alert you to this after a previous email which I may
>         not have
>         >         replied to
>         >         yet (I haven't got a chance to test your new branch
>         yet, but
>         >         the search
>         >         is part of some view widget functionality and is
>         enormously
>         >         useful at
>         >         present).
>         >
>         >         Richard
>         >
>         >
>         >
>         >
>         >
>         > --
>         > Éloi Rivard - address@hidden
>         >
>         > « On perd plus à être indécis qu'à se tromper. »
>         >
>         
>         
>         
> 
> 
> 
> -- 
> Éloi Rivard - address@hidden
>         
> « On perd plus à être indécis qu'à se tromper. »
>