Re: [Denemo-devel] Denemo warnings and code cleanup

[Richard Shann]

On Mon, 2013-06-03 at 10:37 +0200, Éloi Rivard wrote:
> I could not solve the main loop bug, but I maybe have a clue. It seems
> to bug when the file dialog is called in a function called by
> g_child_watch_add.

yes, I think you're right, but life is too short to chase up all these
niggles. I will try and get the translation availability thing done
today.

Richard


> 
> 
> 
> 2013/6/2 Richard Shann <address@hidden>
>         On Sat, 2013-06-01 at 22:08 +0100, Richard Shann wrote:
>         > On Sat, 2013-06-01 at 18:54 +0100, Richard Shann wrote:
>         > > On Thu, 2013-05-30 at 11:34 +0200, Éloi Rivard wrote:
>         > > >
>         > > >
>         > > >
>         > > > 2013/5/27 Richard Shann <address@hidden>
>         > > >         Ah, yes, there are still some commands that are
>         using the old
>         > > >         route,
>         > > >         running an external viewer on a generated file.
>         I have not got
>         > > >         round to
>         > > >         doing anything about those. Can anyone
>         interested say if there
>         > > >         is a good
>         > > >         reason to keep this external pdf view (and
>         indeed the external
>         > > >         png
>         > > >         viewer) code around?
>         > > >
>         > > >         Richard
>         > > > Are you only talking about the png viewer, or the png
>         export ?
>         > >
>         > > I shouldn't have mentioned the png viewer, as we don't
>         have an internal
>         > > png viewer. I have gone over the print menu now, I think
>         the external
>         > > pdf viewer should now be obsolete.
>         >
>         > In fact, I think I have removed the last vestiges of it now.
>         >
>         > >  There is still some thinking needed
>         > > about the png generation which could be treated as a
>         purely export
>         > > feature, even though an external viewer is being called up
>         to show the
>         > > png (?)
>         >
>         > Something like displaying the .png and offering a
>         filechooser to rename
>         > the .png to.
>         
>          Eloi ,
>         Well I tried adapting the code from the remove-viewers branch
>         to do this
>         but hit the snag of the main loop stopping which you reported
>         before. So
>         I have just issued a message giving the file location and
>         opening the
>         viewer. All this is now in the Export menu. I don't think it
>         is worth
>         putting more effort in on this.
>         Enabling people to find the command they want is far more
>         important -
>         another case of someone struggling to find a command came up
>         today.
>         
>         Richard
>         
>         
> 
> 
> 
> -- 
> Éloi Rivard - address@hidden
>         
> « On perd plus à être indécis qu'à se tromper. »
>