Re: [Denemo-devel] Crash: Unable to load the Script

[Richard Shann]

This bug is a showstopper I think. I have fixed it, but when I tried to
check it in it checked in my work in progress instead.
I don't know how to work these git branches.

The fixes look like this (in view.c)

@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

    if(*text==0)
      text = instantiate_script(action);
    if(text)
      return (gboolean)call_out_to_guile(text);

@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

where text is checked before being used and

@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

  if(scheme) {
    if(*scheme==0)
      scheme = instantiate_script(action);
    if(scheme) {
      item = gtk_menu_item_new_with_label("Get Script");
      gtk_menu_shell_append(GTK_MENU_SHELL(menu), item);
      g_signal_connect(G_OBJECT(item), "activate", 
G_CALLBACK(appendSchemeText_cb), scheme);
    }
    item = gtk_menu_item_new_with_label("Save Script");
    gtk_menu_shell_append(GTK_MENU_SHELL(menu), item);

@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

where the menu item is not created if scheme is still NULL after trying
to instantiate the script.

Jeremiah - can you get these fixes into the 0.8.8 branch?

I get this when I try:

 git push
Counting objects: 7, done.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 439 bytes, done.
Total 4 (delta 3), reused 0 (delta 0)
To ssh://address@hidden/srv/git/denemo.git
   2ad72ae..18df264  master -> master
 ! [rejected]        stable-0.8.8 -> stable-0.8.8 (non-fast forward)
error: failed to push some refs to
'ssh://address@hidden/srv/git/denemo.git'

Richard



On Mon, 2009-08-24 at 17:29 +0200, Nils wrote:
> Same for Measures -> Adjust the barlines. And maybe more.
> 
> Nils
> 
> On Mon, 24 Aug 2009 17:26:06 +0200
> Nils <address@hidden> wrote:
> 
> > In the last few days I got here and there an "Unable to load the script" 
> > which crashes Denemo. Latest git.
> > 
> > There were some strange menu entries which did that, but they disappeared 
> > when I removed my ~/.denemo .
> > 
> > But it still happens for Movements->Titles etc. -> Subtitle
> > 
> > I tried it with an empty file right after I deleted ~./denemo and it worked 
> > for subtitle (Or I clicked the wrong Item). But after that it crashed again.
> > 
> > Even if the script is not there or wrong, but why does it crash Denemo if 
> > this popup shows.
> > 
> > Nils
> > 
> > 
> > _______________________________________________
> > Denemo-devel mailing list
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/denemo-devel
> > 
> 
>