[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
patch #8947: Don't try to execute a data file
From: |
Ben Elliston |
Subject: |
patch #8947: Don't try to execute a data file |
Date: |
Tue, 22 Mar 2016 18:15:07 +1100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
Hi Rob
I've just looked at your patch here:
https://savannah.gnu.org/patch/index.php?8947
This seems a bit odd to me:
+ # Don't try to execute a data file, which is used by some tests
+ # to compare output.
+ if {[regexp "^\.txt$" $prog]} {
+ return ""
+ }
Wouldn't it be better to not call unix_load with such an argument?
Also, the patch contains a proc definition called make_absolute. It's
redundant -- Tcl offers `file normalize'.
Cheers,
Ben
signature.asc
Description: Digital signature
- patch #8947: Don't try to execute a data file,
Ben Elliston <=