[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Cvs-dev] Re: [Cvs-test-results] Build CVS (TRUNK) failed.

From: Jim Hyslop
Subject: Re: [Cvs-dev] Re: [Cvs-test-results] Build CVS (TRUNK) failed.
Date: Sun, 11 Jun 2006 21:56:47 -0400
User-agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)

Hash: SHA1

Mark D. Baushke wrote:
> Jim Hyslop <address@hidden> writes:
>>It's a start :=)
> Good. Perhaps if you commit what works, we can see what else still
> fails?

I'm just cleaning up a bit, to make sure the checkin doesn't include any
other work-in-progress.

>>I've been working on this, and once those have been resolved, there's
>>still a problem where client.c tries to call strtoumax(). See the thread
>>in bug-cvs:
> I guess we need to know if there is a uintmax_t type and/or a
> strtoimax() function in your environment or not before anyone else can
> help.

There's an __int64 type, and (as far as I've found) three conversion

char * _i64toa(__int64, char *, int);
char * _ui64toa(unsigned __int64, char *, int);
__int64 _atoi64(const char *);

Now that I've modified the appropriate HAVE_DECL_ definitions in, everything compiles and links if I change
lib/strtoimax.c line 71 from:

  verify (sizeof (INT) == sizeof (long int));


  verify (sizeof (INT) >= sizeof (long int));

>>This also requires modifying windows-NT/config.h to define
>>HAVE_DECL_STRTOLL, and I'm having a difficult time trying to understand
>>the interactions between ./, ./config.h,
>>windows-NT/, etc.
> Ahhh... maybe I can help.

Thanks for the explanation (and thanks, Derek, for adding that
explanation to That's what I thought, but each time I ran the config.h file it generated had some really weird
results. Basically, it was putting in "#undef " statements for some
values that should have been defined, such as CLIENT_SUPPORT.

I finally tracked it down to this line in

        if (/^#\s*define\s*(\w+)(\s+(.+))?$/)

If I understand the line correctly, then the space and any characters
following 'define' should be optional. My Cygwin version of perl
(5.8.7), however, doesn't match the line unless it has at least a space
after the word 'define'.

I'll commit the changes to get it building correctly for now, and we can
discuss whether the change to lib/strtoimax.c is appropriate, or if
there's a better way to handle it.

- --
Jim Hyslop
Dreampossible: Better software. Simply.
                 Consulting * Mentoring * Training in
    C/C++ * OOD * SW Development & Practices * Version Management
Version: GnuPG v1.4.2 (MingW32)
Comment: Using GnuPG with Thunderbird -


reply via email to

[Prev in Thread] Current Thread [Next in Thread]