Re: Bug#628815: coreutils: pinky makes crazy DNS queries

[Pádraig Brady]

On 19/03/2024 10:54, debbug@perkelt.hu wrote:
> I looked into this and found that
> pinky tries to canonicalize the information in the "Where" column
> automaticaly, and it has no option to disable this behaviour.
> see line 285 pinky.c:
>         if (*ut_host)
>                 /* See if we can canonicalize it.  */
>                 host = canon_host (ut_host);
> this results in many unnecessary dns queries.
> For example on a debian system with acpi-support, /etc/acpi/lid.sh will
> make many requests to find the host $WAYLAND_DISPLAY every time the lid
> is opened.
>
> "who" has the --lookup (attempt to canonicalize hostnames via DNS)
> option, and doesn't do it by default.
> Maybe it would be more lightweight to forget about canonicalization
> altogether.

pinky is slow here on Fedora 39 too.
I agree that it should avoid this by default.
pinky is supposed to be a lightweight finger after all.

I'll apply the attached to upstream coreutils soon.

thanks,
Pádraig

pinky-no-dns.patch
Description: Text Data