quoting of strings in errors

[Pádraig Brady]

On 26/10/15 01:51, Pádraig Brady wrote:
> On 25/10/15 18:05, MI wrote:
>> Currently, "md5sum -c" gives a cryptic error when the line endings in the 
>> .md5 file 
>> are not LF (\x0A). It would be helpful if md5sum would just "do the right" 
>> and 
>> understand the 2 other newline standards.
>>
>> .md5 files created on non-Unix systems may use line endings other than LF . 
>> Windows 
>> uses CRLF (\x0D\x0A), and maybe some Mac utility still uses CR (\x0D).
>>
>> The error message is cryptic in a Linux terminal with CRLF files, because it 
>> overwrites the file name, since it just prints out the CR character:
>>
>>      $ md5sum -w -c Some_File_From_Windows.md5
>>      : No such file or directoryWindows.mxf
>>      : FAILED open or readndows.mxf
>>      md5sum: WARNING: 1 listed file could not be read
> 
> This is mainly a quoting issue.  With the attached patch,
> the much more obvious error is output:
> 
>   md5sum: ‘...Windows.mxf\r’: No such file or directory
>   ‘...Windows.mxf\r’: FAILED open or read
>   md5sum: WARNING: 1 listed file could not be read

I noticed there are lots of cases of unquoted output,
so as a follow up I intend to push a change
that satisfies the following "syntax check":

  git grep 'error (.*%s.*, [^(]*);$' src | grep -v quote