[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[hurd,commited] hurd: Don't pass FD_CLOEXEC in CMSG_DATA

From: Samuel Thibault
Subject: [hurd,commited] hurd: Don't pass FD_CLOEXEC in CMSG_DATA
Date: Mon, 24 Apr 2023 23:08:09 +0200

The flags are used by _hurd_intern_fd, which takes O_* flags, not FD_*.

Also, it is of no concern to the receiving process whether or not
the sender process wants to close its copy of sent file descriptor
upon exec, and it should not influence whether or not the received
file descriptor gets the FD_CLOEXEC flag set in the receiving process.

The latter should in fact be dependent on the MSG_CMSG_CLOEXEC flag
being passed to the recvmsg () call, which is going to be implemented
in the following commit.

Fixes 344e755248ce02c0f8d095d11cc49e340703d926
"hurd: Support sending file descriptors over Unix sockets"

Signed-off-by: Samuel Thibault <>
Signed-off-by: Sergey Bugaev <>
 sysdeps/mach/hurd/sendmsg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sysdeps/mach/hurd/sendmsg.c b/sysdeps/mach/hurd/sendmsg.c
index 7106faf0de..3c9cdc4e66 100644
--- a/sysdeps/mach/hurd/sendmsg.c
+++ b/sysdeps/mach/hurd/sendmsg.c
@@ -138,8 +138,8 @@ __libc_sendmsg (int fd, const struct msghdr *message, int 
                                             0, 0, 0, 0);
                   if (! err)
-                  /* We pass the flags in the control data.  */
-                  fds[i] = descriptor->flags;
+                  /* We do not currently have flags to pass.  */
+                  fds[i] = 0;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]