commit-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[hurd] 39/61: trans/fakeroot: remove spurious semicolon


From: Samuel Thibault
Subject: [hurd] 39/61: trans/fakeroot: remove spurious semicolon
Date: Tue, 27 May 2014 08:32:12 +0000

This is an automated email from the git hooks/post-receive script.

sthibault pushed a commit to branch upstream
in repository hurd.

commit 4ece292c3fba7ec8f02b057a069943a325d091db
Author: Justus Winter <address@hidden>
Date:   Fri May 16 12:50:35 2014 +0200

    trans/fakeroot: remove spurious semicolon
    
    A spurious semicolon caused a control flow bug in check_openmodes,
    leading to a port leak.
    
    * trans/fakeroot.c (check_openmodes): Remove spurious semicolon.
---
 trans/fakeroot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/trans/fakeroot.c b/trans/fakeroot.c
index 987af24..0ea3cbf 100644
--- a/trans/fakeroot.c
+++ b/trans/fakeroot.c
@@ -222,7 +222,7 @@ check_openmodes (struct netnode *nn, int newmodes, file_t 
file)
          mach_port_deallocate (mach_task_self (), file);
          file = MACH_PORT_NULL;
        }
-      if (file == MACH_PORT_NULL);
+      if (file == MACH_PORT_NULL)
        {
          enum retry_type bad_retry;
          char bad_retryname[1024];     /* XXX */

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/pkg-hurd/hurd.git



reply via email to

[Prev in Thread] Current Thread [Next in Thread]