commit-gnue
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnue] r9057 - trunk/gnue-common/src/utils


From: reinhard
Subject: [gnue] r9057 - trunk/gnue-common/src/utils
Date: Thu, 23 Nov 2006 04:05:30 -0600 (CST)

Author: reinhard
Date: 2006-11-23 04:05:29 -0600 (Thu, 23 Nov 2006)
New Revision: 9057

Modified:
   trunk/gnue-common/src/utils/version.py
Log:
Minor code improvement.


Modified: trunk/gnue-common/src/utils/version.py
===================================================================
--- trunk/gnue-common/src/utils/version.py      2006-11-20 21:44:50 UTC (rev 
9056)
+++ trunk/gnue-common/src/utils/version.py      2006-11-23 10:05:29 UTC (rev 
9057)
@@ -65,9 +65,9 @@
     filename = tempfile.mktemp('svnrev')
     os.system(cmd + '> %s' % filename)
 
-    f = file(filename, 'r')
-    rev = int(f.read())
-    f.close()
+    tmpfile = file(filename, 'r')
+    rev = int(tmpfile.read())
+    tmpfile.close()
     os.remove(filename)
 
     return rev
@@ -140,10 +140,10 @@
             parameter is C{None}, the SVN revision is determined automatically.
         """
 
-        assert isinstance (major, int) and major < 100
-        assert isinstance (minor, int) and minor < 100
+        assert isinstance(major, int) and major >= 0 and major < 100
+        assert isinstance(minor, int) and minor >= 0 and minor < 100
         assert phase in self.__phases.keys()
-        assert isinstance (build, int) and build < 10
+        assert isinstance(build, int) and build >= 0 and build < 10
 
         self.major = major
         self.minor = minor





reply via email to

[Prev in Thread] Current Thread [Next in Thread]