commit-classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #1820] [Patch #1820] java.security.Security.providers() loops ...


From: noreply
Subject: [patch #1820] [Patch #1820] java.security.Security.providers() loops ...
Date: Thu, 14 Aug 2003 12:13:20 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686) Gecko/20030714 Galeon/1.3.7 Debian/1.3.7.20030803-1

Patch #1820 has been updated. 

Project: 
Category: None
Status: Closed
Summary: java.security.Security.providers() loops ...

Follow-Ups:

Date: Thu 08/14/03 at 17:16
By: crawley

Comment:
This patch fixes an infinite loop in the lazy provider
initialisation code in java.security.Security.  The 
'providers' method calls 'loadProviders' (line 87 or 87), 
which then calls 'provides' (line 138) ... and so on.

The problem occurs in the following Mauve testcase:

  gnu.testlet.java.security.Security.provider

and also causes object serialisation and other testcases
to fail.

[This is a minimal patch to fix the problem.  If it was
my code, I'd also fix the indentation and the poor choice 
of variable names; e.g. 'providers_lazy*'.]


2003-08-xx  Stephen Crawley <address@hidden>
        * java.security.Security (providers) : fix infinite loop in 
initialisation

-------------------------------------------------------

Date: Thu 08/14/03 at 18:13
By: mark

Comment:
Thanks. Obviously correct. Applied as follows (including your other remarks).

2003-08-14  Stephen Crawley  <address@hidden>
                                                                                
       * java/security/Security.java (providers_lazy): Renamed.
       (providersList): Renamed providers_lazy field.
       (providers_lazy_set): Renamed
       (providersInited): Renamed providers_lazy_set field.
       (providers): Set providersInited to true. Reindent.

-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://savannah.gnu.org/patch/?func=detailpatch&patch_id=1820&group_id=85

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]