Re: [PATCH] Field position attribute handling

[Tom Tromey]

>>>>> "Dalibor" == Dalibor Topic <address@hidden> writes:

Dalibor> -    if (! (obj instanceof FieldPosition))
Dalibor> +    if (this == obj)
Dalibor> +      return true;
Dalibor> +
Dalibor> +    if (obj != null && (obj.getClass() != this.getClass()))
Dalibor>        return false;

I think this should read:

  if (obj == null || obj.getClass() != this.getClass())
    return false;

I don't think short-circuiting the this==obj case is really worth the
effort.  But I don't really care all that much.

Dalibor> +    hash = 31 * hash + (null == field_attribute ? 0 : 
field_attribute.hashCode());

Does this line need to be wrapped?  I think it goes past column 79.

Tom