classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Small fix for Jetty 4.2.14


From: Mark Wielaard
Subject: Re: [PATCH] Small fix for Jetty 4.2.14
Date: Thu, 13 Nov 2003 18:13:33 +0100

Hi,

On Thu, 2003-11-13 at 01:29, Dalibor Topic wrote:
> Hi,
> 
> attached is a small fix for Jetty 4.2.14 that is needed to get Jetty to 
> work with Classpath's file URL Connection. Jetty otherwise breaks on 
> startup and complains that webapps/templates can not be found, despite 
> that it exists. Jetty wants to access the path of the file permission on 
> a file URL connection to determine the existence of a file, apparently.
> 
> The fix overwrites getPermission the file URL connection to return a 
> FilePermission with the file path and a read permission.

Thanks. I also wrote a Mauve test for this.
(The test still fails because our file Handler.parseURL() seem broken.
But if that is fixed, your patch makes the new Mauve test succeed.)

2003-11-13  Dalibor Topic <address@hidden>
> 
>         * libraries/javalib/gnu/java/net/protocol/file/Connection.java:
>         Added imports for java.io.FilePermission and
>         java.security.Permission.
>         (permission) New field.
>         (DEFAULT_PERMISSION) New constant.
>         (Connection) Create a FilePermission with permission to read
>         from file.
>         (getPermission) Overwrite getPermission to return a
>         FilePermission.
> 

Applied as follows:

2003-11-13  Dalibor Topic <address@hidden>

       * gnu/java/net/protocol/file/Connection.java (permission): New field.
       (DEFAULT_PERMISSION): New constant.
       (Connection): Create a FilePermission with permission to read file.
       (getPermission): Overwrite getPermission to return a FilePermission.

You don't need to mention really trivial changes such as new imports.
Note the placement of the ':' between what was changed and the
description of the change.

Maybe kaffe could in the long run switch to a separate ChangeLog file in
the libraries/javalib directory so that we can even share the complete
ChangeLog messages between the projects as we already do with gcj
libjava.

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]