Re: Patch: image loading fixes

[Thomas Fitzsimmons]

On Fri, 2003-11-07 at 15:00, Tom Tromey wrote:
> >>>>> "Tom" == Thomas Fitzsimmons <address@hidden> writes:
> 
> Tom> This patch fixes various problems related to image loading.  It also
> Tom> implements Component.imageUpdate, GtkToolkit.prepareImage and the
> Tom> byte-array GtkToolkit.createImage method.
> 
> Looks good.
> 
> Tom> -    // FIXME - gcj local: GdkPixbufDecoder doesn't work.
> Tom> -    // return new GtkImage (new GdkPixbufDecoder (filename), null);
> Tom> -    return null;
> Tom> +    return new GtkImage (new GdkPixbufDecoder (filename), null);
> 
> I don't remember why I commented out this code in libgcj, other than
> what the comment says.  I assume it is ok to enable now?
> 

Yes, we can remove these FIXMEs since Graydon fixed GdkPixbufDecoder.

> Tom> +    boolean incrementalDraw = Boolean.getBoolean 
> ("awt.image.incrementalDraw");
> Tom> +    Long redrawRate = Long.getLong ("awt.image.redrawrate");
> 
> Should these be computed once, at class init time?

Yes, looking again, I think they should.

> Or do we want to recompute them each time this method is called?
> 
> Also, I forget where and how we're documenting properties we
> recognize.  I know this has come up before though.  These two should
> at least be mentioned in the javadoc for the method.
> 

Yup, they're already mentioned in the existing javadoc.

Are the attached changes to Component.java ok?  If so, I'll check them
in along with the rest of the patch.

Tom

imageobserver3.patch
Description: Text Data