classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: classpath ./ChangeLog ./THANKYOU java/util/Reso...


From: Brian Jones
Subject: Re: classpath ./ChangeLog ./THANKYOU java/util/Reso...
Date: 06 Jan 2003 16:03:11 -0500
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2

Tom Tromey <address@hidden> writes:

> >>>>> "Brian" == Brian Jones <address@hidden> writes:
> 
> Brian>        2003-01-05  Julian Dolby  <address@hidden>
> Brian>        * java/util/ResourceBundle.java (tryBundle): If an exception
> Brian>        occurs, do not try to use the bundle.
> 
> This part of the patch looks like this:
> 
> @@ -509,6 +523,7 @@
>      catch (Exception ex)
>        {
>          // ignore them all
> +     foundBundle = null;
>        }
>      if (foundBundle == null)
>        {
> 
> I think this is unnecessary.  The assignment to `foundBundle' will
> never happen if there is an exception.  I'm inclined to revert this
> part, as it is a libgcj/classpath divergence and is a little easier to
> fix here.

This is true, but the code is harmless and I was inclined to believe
necessary for JRVM for some reason.  If it isn't needed (Dolby?) then
surely revert that part.

Thanks,
Brian
-- 
Brian Jones <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]