classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: JEditorPane Scrollable fix


From: Anthony Balkissoon
Subject: [cp-patches] FYI: JEditorPane Scrollable fix
Date: Thu, 27 Oct 2005 16:32:31 -0400

This patch makes us pass
gnu/testlet/javax/swing/JEditorPane/getScrollableTracks.java

We were always returning false for getScrollableTracksViewportWidth (and
Height), the O'Reilly Swing book said we should always return true, but
the Mauve tests indicated that neither of these was right.

Since packing validates the component and packing makes these methods
return true, I've implemented them to return isValid and this passes the
Mauve tests.  I can find no documentation to support this or any other
implementation, so if it's wrong, future test apps will have to show
that and will have to be converted into more specific Mauve test cases.

For now, this is committed.


2005-10-27  Anthony Balkissoon  <address@hidden>

        * javax/swing/JEditorPane.java:
        (getScrollableTracksViewportWidth): Return true if the component is 
        valid.
        (getScrollableTracksViewportHeight): Likewise.

--Tony

Attachment: JEditorPaneScrollableTracks.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]